Show area name when moving between areas by renato-sy · Pull Request #2818 · endlessm/threadbare

renato-sy · 2026-09-02T00:40:59Z

Add an area name banner that appears when the player enters a new area. The banner is shown for a few seconds when moving between areas such as Fray's End and Song Sanctuary.
Resolves #2340

…ame and re-entry components

github-actions · 2026-09-02T01:08:48Z

Play this branch at https://play.threadbare.game/branches/renato-sy/main/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

…ing in area name and re-entry components

manuq · 2026-09-02T15:08:14Z

@renato-sy I see you continue pushing changes, so please let us know when you are ready to receive a review. Thanks!

renato-sy · 2026-09-03T22:36:19Z

Okay, I think that's it; the pulls I was doing were just little things Git required to perform the merge.

…fix parameter spacing, and remove trailing whitespace

…order definitions

manuq · 2026-09-04T21:27:43Z

@renato-sy sorry for the delay. I wil have to review this on Monday. For the moment, please consider that there are other entry points to Fray's End:

From the east.
From the north (from Song Sanctuaries)
From the west (from Fray's End West, after completing the Void quest)
And another from the south (from Dev Archipelago, see image below)

I think entering from any of those should display the area name.

In fact all those have areas to block the exit, so maybe the entry areas should be next to them.

renato-sy · 2026-09-06T00:01:04Z

Hey there! I've already mapped out the routes for Frays End, Frays End West, and Song Sanctuary, but I'm not sure where we could put the entrance to the area in Linenville—I don't see any villages or anything like that.

And I'm not sure if it's appropriate to also include the area alert when leaving a quest.

…nd UI updates

…e and newlines

wjt · 2026-09-07T13:33:44Z

Linenville doesn't exist yet as an area you can walk to on the map - the upwards route in that screenshots is blocked even once you complete the void quest and push back that patch of void.

I personally wouldn't include the area name when leaving (i.e. abandoning?) a quest. At the end of a normal quest, when you're teleported back to the middle of Fray's End, I don't think the banner is needed. But I would include it when you first reach Fray's End at the end of the tutorial, i.e. at the spawn point circled at the bottom-left here:

renato-sy · 2026-09-07T18:26:04Z

Okay, so Linenville isn't there. On the other hand—I don't know what you think about this—regarding the names that appear when entering an area, I placed it on the bridge, as if you were just arriving.

Just like in Song Sanctuary, I placed it on the bridge to indicate that the green section belongs to Routes or Fray's End, while the red part is a different area.

However, if you'd like, I could set it up so that a notification showing the zone's name appears at the spawn points when the first move is made. And if so, would the animation be only once (the animation is instantiated and then destroyed; we would have to go to another area and re-enter the area to see the name) or many times (like it is now but in the spawn points)

reentry

first entry

wjt · 2026-09-08T16:03:52Z

Yes, the different-coloured grass on the two sides of the bridge is meant to mark the boundary to the Song Sanctuary, so I agree that the trigger should be crossing that bridge from bottom to top!

renato-sy · 2026-09-08T16:15:14Z

Okay, so are we all set, or do I need to make any changes?

wjt · 2026-09-08T17:42:58Z

Sorry, I have not tested or reviewed the code changes yet!

wjt

I confess that I haven't read the implementation in detail but I don't think the behaviour is correct. Walking around Fray's End I can trigger the banner repeatedly even though I've never left Fray's End!

Screencast.From.2026-09-09.13-22-21.mp4

I would approach it something like this:

In the game state, store the current area name, and a set of areas we have seen before
Place area name triggers (Area2D with name property) in roughly the places you have done
When a trigger detects the player:
- If the current area name in the game state matches the trigger's name, do nothing
- Else:
  - Set the current area name in the game state to the trigger's name
  - If the current area has not been seen before:
    - Show the "big" notification
    - Add it to the set of seen areas
  - Else, show the "small" notification.

With this approach, I don't think you need the "directions" property on the triggers.

renato-sy · 2026-09-14T00:03:53Z

I’ve fixed the issue you mentioned and switched the comments to English; you can check if the project.godot file has been reverted.

wjt · 2026-09-14T12:07:09Z

+## Emitted when an area's unlock status changes.
+signal area_changed(area_name: String, is_unlocked: bool)


This signal's second parameter is never false so personally I would change this to:

Suggested change

## Emitted when an area's unlock status changes.

signal area_changed(area_name: String, is_unlocked: bool)

## Emitted when an area is unlocked (i.e. first encountered)

signal area_unlocked(area_name: String)

This signal is not actually used anywhere...

I think a better design would be:

Change this signal to signal area_changed(area_name: String, first_visit: bool)

Have the HUD scene connect to this signal and, when it is emitted, show the appropriate balloon - this keeps the UI responsibility in one place

Then make the triggers be an Area2D (which can have multiple shapes in different parts of the scene if desired - or a huge polygon that covers the relevant area) which only adjust the state (and don't contain a new CanvasLayer)

So, would I move both of them to the HUD (first_unlock and re_entry)? The first one self-destructs, so I don't think there would be a problem—or I don't know, what do you think?

I don't think that question was necessary, haha, since when I copied and pasted the instance, it instantiates right into the HUD

wjt · 2026-09-14T12:09:02Z

I don't like how this looks with the heavy drop shadow. Personally I think we could use the same presentation as the dialogue balloons.

Okay, I've applied the "Balloons" one. Take a look—how does the color look? Should I change it?

… in game state and UI components

renato-sy · 2026-09-16T15:20:01Z

I can review what you mentioned.

renato-sy · 2026-09-17T23:04:10Z

Hi, I can do the review.

KarmDK · 2026-09-21T08:10:09Z

Hi, I've been looking into this, and I've noticed the following:

When entering Frays End via any entrance other than the southern one on the left, the small notification doesn't appear.
Neither the large nor the small notification appears for the Dev Archipelago.

renato-sy · 2026-09-22T23:41:45Z

Okay, I'll check right now to see what's going on.

manuq · 2026-09-23T10:44:42Z

The changes in project.godot are unrelated, please revert the file.

manuq · 2026-09-23T12:12:58Z

+zone_name = "Song 
+Sanctuary"


Please avoid separating the text with newlines for the presentation. The label wrapping should take care of it. Keep in mind that these zone names could be translated to other languages in the future. I learned this the hard way and had to fix all signposts #2843

Suggested change

zone_name = "Song

Sanctuary"

zone_name = "Song Sanctuary"

manuq · 2026-09-23T12:13:14Z

+zone_name = "Dev 
+Archipelago"


Suggested change

zone_name = "Dev

Archipelago"

zone_name = "Dev Archipelago"

manuq · 2026-09-23T12:16:47Z

+# SPDX-License-Identifier: MPL-2.0
+extends Node2D
+
+@export_multiline var zone_name: String


As stated above, this shouldn't be multiline. Also, we may want to translate the zone names in the future, and the easiest way to do it is by making this match the "*_text" pattern. I have learned this week about it when working on #2945 (I had to rename a property from action to action_text. I also proposed this to be documented in godotengine/godot-docs#12394

Suggested change

@export_multiline var zone_name: String

@export var zone_name_text: String

manuq · 2026-09-23T12:17:47Z


+[node name="LineVillePath" parent="." unique_id=1184526213 instance=ExtResource("59_6fau3")]
+direcciones_salida = 87
+zone_name = "Frays end"


The name of this zone, as shown in several dialogues is "Fray's End".

Suggested change

zone_name = "Frays end"

zone_name = "Fray's end"

manuq · 2026-09-23T12:20:33Z

 debug_color = Color(0.9610079, 0, 0.5155429, 0.41960785)

+[node name="LineVillePath" parent="." unique_id=1184526213 instance=ExtResource("59_6fau3")]
+direcciones_salida = 87


This seems to be a leftover.

Suggested change

direcciones_salida = 87

manuq · 2026-09-23T12:20:42Z

+polygon = PackedVector2Array(2937, 765, 2943, 961, 2700, 1108, 2684, 648)
+
+[node name="StartPath" parent="." unique_id=1388956016 instance=ExtResource("59_6fau3")]
+direcciones_salida = 49


Suggested change

direcciones_salida = 49

manuq · 2026-09-23T12:20:57Z

+polygon = PackedVector2Array(953, 1344, 1033, 1345, 1033, 1374, 951, 1374)
+
+[node name="SongSanctuaryPath" parent="." unique_id=234964131 instance=ExtResource("59_6fau3")]
+direcciones_salida = 194


Suggested change

direcciones_salida = 194

manuq · 2026-09-23T12:21:05Z

+polygon = PackedVector2Array(2175, 280, 2834, 283, 2682, -9, 2363, -16, 2166, 164)
+
+[node name="DevArchipelagoPath" parent="." unique_id=1511301874 instance=ExtResource("59_6fau3")]
+direcciones_salida = 49


Suggested change

direcciones_salida = 49

manuq · 2026-09-23T12:21:14Z

+polygon = PackedVector2Array(2810, 1772, 2574, 1766, 2573, 1717, 2810, 1716)
+
+[node name="WestEndPath" parent="." unique_id=681218199 instance=ExtResource("59_6fau3")]
+direcciones_salida = 168


Suggested change

direcciones_salida = 168

manuq · 2026-09-23T12:27:13Z

@renato-sy this is promising! Check this video. If I start the game from scratch, skip the tutorial, then go north I see "Frays End" when exiting. I think that's wrong, it should happen when entering.

zones.webm

andree-git and others added 7 commits August 21, 2026 23:54

Feat: implementado cartel de nombre de zona en el mapa de Frays End

28e745d

fix: adjust text positioning and add animations

4577c68

fix: adjust text positioning and add animations

87c17bc

Merge branch 'endlessm:main' into main

d574e6c

fix: adjust text positioning and add animations

299e3bf

feat: add area name and re-entry UI components with animations

af863b7

fix: correct variable names and ensure proper text handling in area n…

3a08106

…ame and re-entry components

renato-sy requested a review from a team as a code owner September 2, 2026 00:41

andree-git added 2 commits September 2, 2026 09:19

fix: remove redundant variable declarations and ensure proper formatt…

7362531

…ing in area name and re-entry components

fix: reorder variable declarations for clarity in area name component

da98b3d

andree-git and others added 3 commits September 3, 2026 19:45

feat: implement area unlock system with UI updates and animations

ee87210

Fix linting errors in re_entry.gd: remove comments before variables, …

d2d0fde

…fix parameter spacing, and remove trailing whitespace

Fix linting errors in area_name.gd: remove trailing whitespace and re…

9035f05

…order definitions

andree-git and others added 3 commits September 5, 2026 19:23

feat: add area name and re-entry components with collision handling a…

8f03895

…nd UI updates

fix: normalize zone name for area unlock checks by removing whitespac…

fce350a

…e and newlines

Merge branch 'endlessm:main' into main

e355dff

wjt reviewed Sep 9, 2026

View reviewed changes

Comment thread project.godot

Comment thread scenes/ui_elements/hud/components/hud.gd Outdated

Comment thread scenes/globals/game_state/global_state.gd Outdated

Comment thread scenes/ui_elements/area_name/components/area_name.gd

Comment thread scenes/ui_elements/hud/components/hud.gd Outdated

renato-sy and others added 2 commits September 13, 2026 17:16

Merge branch 'endlessm:main' into main

3bea70e

Refactor area name handling: rename scene files and update references

2845897

wjt requested changes Sep 14, 2026

View reviewed changes

Enhance area unlock system: update signals and refactor area handling…

b1c17ac

… in game state and UI components

renato-sy requested a review from wjt September 15, 2026 03:18

Merge branch 'endlessm:main' into main

6e73bdf

manuq requested changes Sep 23, 2026

View reviewed changes

		## Emitted when an area's unlock status changes.
		signal area_changed(area_name: String, is_unlocked: bool)

	@export_multiline var zone_name: String
	@export var zone_name_text: String

Conversation

renato-sy commented Sep 2, 2026

Uh oh!

github-actions Bot commented Sep 2, 2026

Uh oh!

manuq commented Sep 2, 2026

Uh oh!

renato-sy commented Sep 3, 2026

Uh oh!

manuq commented Sep 4, 2026

Uh oh!

renato-sy commented Sep 6, 2026

Uh oh!

wjt commented Sep 7, 2026

Uh oh!

renato-sy commented Sep 7, 2026

Uh oh!

wjt commented Sep 8, 2026

Uh oh!

renato-sy commented Sep 8, 2026

Uh oh!

wjt commented Sep 8, 2026

Uh oh!

wjt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renato-sy commented Sep 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

renato-sy commented Sep 16, 2026

Uh oh!

renato-sy commented Sep 17, 2026

Uh oh!

KarmDK commented Sep 21, 2026

Uh oh!

renato-sy commented Sep 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manuq commented Sep 23, 2026

Uh oh!