Sequence puzzle: Make hint signs optional - #2908
Closed
BiancaPierina wants to merge 6 commits into
Closed
BiancaPierina wants to merge 6 commits into
BiancaPierina wants to merge 6 commits into
Conversation
- Cat walk animation - Cat wink animation - Aseprite of cat walk and cat wink
-Correction of the walking cat image size -Correction of the winking cat image size
- Added shadow ellipse to the cat walk frames - Flipped the cat walk assets to face right - Added blinking and head movement to the cat idle animation
- Remove the mandatory hint_sign check from _get_configuration_warnings in sequence_puzzle_step.gd. - Add is_solved state property (@export var is_solved: bool = false) directly to the sequence puzzle step to track solved states independently of hint signs. - Fixes the limitation where scenes with environmental clues required dummy hint signs.
|
Test build no longer available. |
This reverts commit a859470.
- Removed the editor warning that required a hint sign. - Added is_solved to SequencePuzzleStep. - Updated SequencePuzzle to use step-level solved state. - Added null guards around all hint_sign access.
Contributor
|
Hi! We opened a new PR for this issue because main had the commits from Pierina's previous issue, which were squash-merged, so this PR still considers them recent changes. Here's the new PR: #2924 |
Collaborator
|
@Arebuayon ok thanks! Let's close this one then. I don't see any conflicts though, so it looks like GitHub could deal with this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress: The puzzle can be played without a hint sign, but I am still investigating why completing the sequence does not advance to the next level.
#2149