Skip to content

Update cliffs in El Juguete Perdido - #2921

Merged
manuq merged 9 commits into
endlessm:mainfrom
KarmDK:2723
Sep 22, 2026
Merged

manuq merged 9 commits into
endlessm:mainfrom
KarmDK:2723

Conversation

@KarmDK

@KarmDK KarmDK commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Updates scenes/quests/story_quests/el_juguete_perdido/1_stealth/stealth.tscn, scenes/quests/story_quests/el_juguete_perdido/2_combat/combat.tscn and scenes/quests/story_quests/el_juguete_perdido/3_sequence_puzzle/sequence_puzzle.tscn to use tiles/elevation_2.tres, replacing the old resource tiles/elevation.tres.
Resolves #2723

@KarmDK
KarmDK requested review from a team as code owners September 17, 2026 23:59
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown

Test build no longer available.

@manuq

manuq commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

For someone wanting to review or verify this, please:

  • Play the affected scenes from main and take screenshots.
  • Then play the scenes from this branch and take screenshots too.

The look and feel should be the same or similar (there may be changes due to painting the elevations with the terrain). The gameplay shouldn't be affected.

You can use the playable link above and https://play.threadbare.game/branches/endlessm/main/ for main. See how to build links to the specific scenes: https://github.com/endlessm/threadbare/wiki/Grabbing-URLs-for-specific-Threadbare-scenes

@manuq

manuq commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

@KarmDK maybe you can verify or review someone else from the open PRs? And receive a review for your own work in exchange?

@KarmDK

KarmDK commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@manuq I would like to do it.

@manuq

manuq commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

@Un-player0

Copy link
Copy Markdown
Contributor

@KarmDK I've reviewed your changes and found out the following:

All scenes have the cliffs properly set and it's not possible to go out-of-bounds
In scene el_juguete_perdido/1_stealth/stealth.tscn, There are small inconsistencies in the cliff decorations, nothing game breaking.

Original
main2

Your changes
pr2


Original
main3

Your changes
pr3

@KarmDK

KarmDK commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

Oh, I hadn't realized. The changes must have already been made!

@Un-player0 Un-player0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@manuq

manuq commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

@Un-player0 thanks a lot for testing and reviewing! I will trust you and merge it.

@manuq
manuq merged commit f9a6c20 into endlessm:main Sep 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cliffs in El Juguete Perdido

4 participants