Skip to content

Give townies names - #2922

Open
edwardvilcamonje-max wants to merge 13 commits into
endlessm:mainfrom
edwardvilcamonje-max:random-townie-names
Open

edwardvilcamonje-max wants to merge 13 commits into
endlessm:mainfrom
edwardvilcamonje-max:random-townie-names

Conversation

@edwardvilcamonje-max

@edwardvilcamonje-max edwardvilcamonje-max commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Add a random name generator for Townies using a shared list of textile-inspired names. Names are not separated by gender, allowing any name to be assigned to any Townie appearance. The generated name remains the same for the Townie instance.

Resolves #2444

@edwardvilcamonje-max
edwardvilcamonje-max requested a review from a team as a code owner September 18, 2026 00:09
@edwardvilcamonje-max edwardvilcamonje-max changed the title Random townie names Give townies names #2444 Sep 18, 2026
@edwardvilcamonje-max edwardvilcamonje-max changed the title Give townies names #2444 Give townies names Sep 18, 2026

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many unrelated changes but I see where this is going by reading random_name.gd. Still, I don't see how can the name be used in a dialogue if it's not part of the CharacterRandomizer class. Please add it there like this:

## The random seed of this character. Setting another character to the same seed
## will make them identical. Setting it to zero will reset the skin color.
@export var character_seed: int

## The character name. Like sprites and palette, this is picked randomly using the
## [member character_seed].
@export var character_name: String

And also as the documentation comment says, please make it work with the character seed. The same seed number should give the same name when you click "Update":

Image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too. The file was removed and has no relationship with the task.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo siento, eso fue un error. Eso pertenece a otro tema en el que trabajé, y se envió por accidente.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the name of the file I can tell this is a test. The other one random_name.gd seems more complete. However this one is the script attached:

Image

@edwardvilcamonje-max
edwardvilcamonje-max requested a review from a team as a code owner September 22, 2026 19:48

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardvilcamonje-max sorry but this has unintended changes again. Also please don't remove the documentation comments from townie.tscn. Thanks!

@edwardvilcamonje-max

Copy link
Copy Markdown
Contributor Author
image I already did it, it's fine, I corrected the mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give townies names

2 participants