Skip to content

Adjust tree collision shape to prevent player from getting stuck and unraveling - #2938

Closed
Brandon-code96 wants to merge 9 commits into
endlessm:mainfrom
Brandon-code96:fix/conflicts-2895
Closed

Brandon-code96 wants to merge 9 commits into
endlessm:mainfrom
Brandon-code96:fix/conflicts-2895

Conversation

@Brandon-code96

@Brandon-code96 Brandon-code96 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Fix collision geometry for the problematic tree near the water edge at the game's start.

  • Replaced the default CircleShape2D with an adjusted CapsuleShape2D to provide smoother navigation.
  • Prevents the player character from becoming trapped inside the collision area and triggering an unintended unraveling/respawn after 2 seconds.

Resolves #2895

@Brandon-code96
Brandon-code96 requested a review from a team as a code owner September 20, 2026 23:14
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/Brandon-code96/fix/conflicts-2895/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@KarmDK

KarmDK commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

hi! I suggest you follow the instructions wjt gave you here.

@KarmDK

KarmDK commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

The correct format is:
#2895
You should edit it.

@Brandon-code96

Copy link
Copy Markdown
Contributor Author

"Hi @KarmDK ! The merge conflicts with the translation files have been resolved on a separate branch, and the PR is ready for your review again. Thank you!"

@wjt wjt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes every tree in the game. I don't think that's what you intended!

@KarmDK

KarmDK commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@Brandon-code96 Maybe you should change the location of the tree only so as not to modify all the trees. Also, if possible, you could do the same with the tree on the right, where I have seen the same thing (the character bounces and if you keep walking, he also gets unraveled).

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would change every tree in the game! As @KarmDK explains, please provide a solution for the affected scene only. Check the ticket, it references it as:

res://scenes/quests/lore_quests/quest_000/1_ruined_village/tutorial_ruined_village.tscn

@manuq

manuq commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

@KarmDK thanks for reviewing this and explaining the PR conventions!

@Brandon-code96

Copy link
Copy Markdown
Contributor Author

Closing this in favor of a new isolated PR that fixes the issue using editable children to prevent global side effects.

@Brandon-code96
Brandon-code96 deleted the fix/conflicts-2895 branch September 22, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Player gets stuck on specific tree near water and unravels in first tutorial scene

4 participants