Adjust tree collision shape to prevent player from getting stuck and unraveling - #2938
Brandon-code96 wants to merge 9 commits into
Conversation
…matting for Mothsache endlessm#1020
Also refresh the Spanish translation!
…ng stuck and unraveling endlessm#2895
|
Play this branch at https://play.threadbare.game/branches/Brandon-code96/fix/conflicts-2895/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
|
hi! I suggest you follow the instructions wjt gave you here. |
|
The correct format is: |
|
"Hi @KarmDK ! The merge conflicts with the translation files have been resolved on a separate branch, and the PR is ready for your review again. Thank you!" |
wjt
left a comment
There was a problem hiding this comment.
This changes every tree in the game. I don't think that's what you intended!
|
@Brandon-code96 Maybe you should change the location of the tree only so as not to modify all the trees. Also, if possible, you could do the same with the tree on the right, where I have seen the same thing (the character bounces and if you keep walking, he also gets unraveled). |
There was a problem hiding this comment.
This would change every tree in the game! As @KarmDK explains, please provide a solution for the affected scene only. Check the ticket, it references it as:
res://scenes/quests/lore_quests/quest_000/1_ruined_village/tutorial_ruined_village.tscn
|
@KarmDK thanks for reviewing this and explaining the PR conventions! |
|
Closing this in favor of a new isolated PR that fixes the issue using editable children to prevent global side effects. |
Fix collision geometry for the problematic tree near the water edge at the game's start.
Resolves #2895