Skip to content

Updated vertical door opened sprite - #2940

Merged
manuq merged 1 commit into
endlessm:mainfrom
Nilu501:main
Sep 22, 2026
Merged

manuq merged 1 commit into
endlessm:mainfrom
Nilu501:main

Conversation

@Nilu501

@Nilu501 Nilu501 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Updated the vertical door opened sprite to include the blue panel and match the existing door design. The sprite position was also adjusted in vertical_door.tscn to keep it aligned with the closed door.

Resolves #2821

@Nilu501
Nilu501 requested a review from a team as a code owner September 21, 2026 06:02
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Test build no longer available.

@joshuajenner

joshuajenner commented Sep 21, 2026

Copy link
Copy Markdown

The closed door sprite has two handles. I'm being very nitpicky here but wouldn't it make more sense for the door to split in the middle when open?

@manuq

manuq commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

The closed door sprite has two handles. I'm being very nitpicky here but wouldn't it make more sense for the door to split in the middle when open?

@joshuajenner this is a very good point! I haven't noticed it. I think it would be better to remove the corresponding handle from the vertical closed door asset. This way it can be flipped, and also matches the horizontal door. What do you think @joshuajenner @Nilu501? We can do that in a followup ticket. I'll merge this one and open a new ticket.

@manuq
manuq merged commit 0446fa3 into endlessm:main Sep 22, 2026
7 checks passed
@Nilu501

Nilu501 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

El sprite de la puerta cerrada tiene dos manijas. Estoy siendo muy quisquilloso, pero ¿no tendría más sentido que la puerta se dividiera por la mitad al abrirse?

@joshuajenner¡Ese es un muy buen punto! No me había dado cuenta. Creo que sería mejor quitar la manija correspondiente del elemento de la puerta vertical cerrada. De esta manera se puede voltear y también coincide con la puerta horizontal. ¿Qué opinas?@joshuajenner @Nilu501Podemos hacerlo en un ticket de seguimiento. Combinaré este y abriré un nuevo ticket.

I hadn’t noticed that before, but I agree. I can make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VerticalDoor: Add blue panel to the "door opened" sprite

3 participants