888: Fix get_duplicate_forecasts() deprecation message - #1232
Open
nikosbosse wants to merge 2 commits into
Open
nikosbosse wants to merge 2 commits into
nikosbosse wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 41 41
Lines 2331 2333 +2
=======================================
+ Hits 2312 2314 +2
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nikosbosse
commented
Sep 24, 2026
nikosbosse
left a comment
Collaborator
Author
There was a problem hiding this comment.
lgtm.
I slightly prefer the order of types, counts vs. counts, types, but not breaking code is also nice
The message said the type argument was deprecated as of 2.2.0. What is deprecated is calling on a plain data.frame without type, as of 2.3.0. Custom text via I() needs lifecycle >= 1.0.2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
nikosbosse
force-pushed
the
fix-get-duplicate-forecasts-type
branch
from
September 25, 2026 17:19
dd34fd5 to
c04b47f
Compare
Fixes namespace_linter in lint-changed-files. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE: Fixes the deprecation warning added in #1148 (#888), before it ships in 2.3.0.
Problem
Calling
get_duplicate_forecasts()on a plain data.frame withouttypewarned:That says the opposite of what is meant. The
typeargument isn't deprecated; calling without it is. The details line then tells users to passtype, which contradicts the first line. The version is also wrong: the change ships in 2.3.0.Fix
The message now reads:
lifecycle::deprecate_warn(what = I(...)), which needs lifecycle ≥ 1.0.2 (from 2022).DESCRIPTIONnow requires that version.The argument order stays as #1148 has it:
data, forecast_unit, type, counts. Earlier revisions of this PR movedtypeand added a check on its value; after discussion we dropped that in favour of this minimal fix.🤖 Generated with Claude Code