Skip to content

feat: check CSS-wide keywords in use-baseline - #542

Merged
lumirlumir merged 1 commit into
mainfrom
feat/use-baseline-css-wide-keywords
Aug 30, 2026
Merged

feat: check CSS-wide keywords in use-baseline#542
lumirlumir merged 1 commit into
mainfrom
feat/use-baseline-css-wide-keywords

Conversation

@Pixel998

@Pixel998 Pixel998 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What did you do?

/* eslint css/use-baseline: ["error", { available: 2021 }] */

a {
  font-size: revert-layer;
}

What did you expect to happen?

The declaration to be reported. revert-layer only reached Baseline in 2022, so with { available: 2021 } it is not yet available.

What actually happened?

No error is reported.

What is the purpose of this pull request?

This PR makes use-baseline check CSS-wide keywords.

What changes did you make? (Give an overview)

  • Added a globalKeywords map to the generated baseline data, sourced from the css.types.global_keywords.* compat keys.
  • checkPropertyValueIdentifier now consults that map before the per-property propertyValues lookup.

Additional comments

revert-rule is not covered. web-features does not expose it yet, so there is no Baseline status to check against. The pattern added here already matches its compat key, so it will be picked up automatically.

Is there anything you'd like reviewers to focus on?

@nzakas nzakas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just waiting another day to give others time to review.

@DMartens DMartens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks. Leaving open for a second review.
Edit: As it has two reviews, moving to merge candidates.

@DMartens DMartens moved this from Needs Triage to Merge Candidates in Triage Aug 26, 2026
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 30, 2026

@lumirlumir lumirlumir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

It’s been four more days, so I’m merging it.

@lumirlumir
lumirlumir merged commit 506bdbb into main Aug 30, 2026
39 checks passed
@lumirlumir
lumirlumir deleted the feat/use-baseline-css-wide-keywords branch August 30, 2026 13:41
@github-project-automation github-project-automation Bot moved this from Merge Candidates to Complete in Triage Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion feature

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants