chore(deps): bump go-libp2p and p2p-forge, bound broker HTTP timeout - #5605
Open
gacevicljubisa wants to merge 2 commits into
Open
chore(deps): bump go-libp2p and p2p-forge, bound broker HTTP timeout#5605gacevicljubisa wants to merge 2 commits into
gacevicljubisa wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018y5vRkWCtKi7RMuJbfjUR5
sbackend123
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Bumps
go-libp2pv0.48.0 → v0.49.0 andipshipyard/p2p-forgev0.7.0 → v0.10.1, and sets an explicit HTTP timeout on the p2p-forge client.Fixes picked up by the upgrades:
401against load-balanced endpoints. The PeerID-auth handshake is two requests, and without a session-affinity cookie the second can hit a backend that never minted the challenge. Bee's default isregistration.libp2p.direct, exactly the affected endpoint.replacesrejection.Conn.Closeis called from a connection-notification path (bee disconnects peers from exactly there, on handshake failure and blocklisting), plus address-reachability-manager fixes and a 64-address-per-peer peerstore cap.The one code change:
p2pforge.WithHTTPClient(&http.Client{Timeout: forgeHTTPTimeout}). The DNS-01 challenge POST previously went throughhttp.DefaultClient, which has no timeout, and nothing in the certmagic ACME path sets a deadline on the context it hands down, so a stalled broker connection would hang for the lifetime of the node.WithHTTPClientis new in p2p-forge v0.8.1.Every
go.modline is a consequence of these two upgrades —go mod tidyon master produces no diff. Notable transitive bumps:certmagicv0.21.6 → v0.25.3,prometheus/client_golangv1.22.0 → v1.24.1,libdnsv0.2.2 → v1.1.1.quic-gostays at v0.60.0.Verified:
go build ./...andgo vet ./...clean,golangci-lint run ./pkg/p2p/...reports 0 issues,go test -race ./pkg/p2p/...passes. The two failures ingo test ./...(TestPanicRespond,TestGsocWebsocketMessageOrdering) reproduce identically on master. Not run:make test-integrationand a cluster smoke test — worth a beelocal run before merge, since theprometheus/client_golangjump touches every metrics package.Open API Spec Version Changes (if applicable)
None.
AI Disclosure