fix: address leftover open bugs - #17
Merged
Merged
Conversation
slapec93
commented
Sep 24, 2026
Collaborator
- Bytes copies its input, so changing the caller's array later no longer changes the object.
- base32 pads to a multiple of 8, as RFC 4648 specifies (it used to pad to 4)
- hexToUint8Array throws on invalid or odd-length hex
- rsEncode([]) throws a clear error instead of a TypeError
- xorCypher throws on an empty key instead of returning the input unchanged
- Stamper rejects a batch depth that isn't a whole number above 16
- indexOf returns start for an empty needle instead of -1
Cafe137
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.