fix(data): name the Marantz FM antenna connector, fix an archive url - #908
Conversation
The FM antenna jack is a threaded 75 ohm coaxial F connector, not a connector without a standard name. `f-type` joins the vocabulary and five Marantz entries use it. The M-CR612's url answered 200 only via a 301 to the archive path, so it now names that path. Settles catalog-submissions 81 and the evidenced half of 82. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CNZwSZ1xLP7uxJgVTnNuFf
🦋 Changeset detectedLatest commit: 598e0d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: existential-engineering/catalog/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. WalkthroughThe PR adds ChangesMarantz metadata
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
`schema/CONTEXT.md` is generated from the schema files, so adding a connection value without regenerating it fails the validate job's up-to-date check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CNZwSZ1xLP7uxJgVTnNuFf
Description
Settles two more
catalog-submissionsfindings, plus one confirmed with nochange needed.
FM antenna connector (submissions #82, the evidenced half). Five Marantz
entries recorded their FM antenna jack as
connection: proprietary, whichasserts the connector has no standard name. It has one — the threaded 75 ohm
coaxial F connector — read off the NR1711's own rear-panel photograph
(chrome threaded stud, centre socket, silkscreened FM 75 ohm) and confirmed per
model by the F-plug on the supplied indoor antenna in each owner's manual's
accessories figure.
f-typejoinsschema/io-connections.yaml, which the repostates is meant to grow when an import surfaces a legitimate new value.
Deliberately not
bnc: that is a bayonet connector, not a threaded one.marantz-nr1711proprietaryf-typemarantz-sr6015proprietaryf-typemarantz-sr7015proprietaryf-typemarantz-cinema-30proprietaryf-typemarantz-av8805aproprietaryf-typeThe last two are not named in the finding. A catalog-wide survey of FM antenna
ports found them carrying the identical port name under the identical wrong
value, so fixing three of five would have left the vocabulary addition
half-applied on its own maker. The two
bnchits that survey returned areMADI and word-clock ports on RME interfaces, correctly BNC; two Tascam FM
antennas read
built-in, a different maker with no evidence here, so both areleft alone.
Archive url (submissions #81).
marantz-m-cr612'surlpointed at/en-us/product/network-audio-players/…, which answers 200 only by way of a301 to
/en-us/product/archive-network-audio-players/…. Verified both legs;the archive path serves 200 directly. Marantz moves a product's path rather
than its id when it archives one. A sweep of every
discontinuedMarantz entryfound M-CR612 was the only one still carrying a pre-archive path.
Two corrections to the findings themselves
proprietary; three did. The six Bluetooth andWi-Fi antenna mounts it describes are not in the catalog as
ioentries atall, so there is nothing to retype and the
sma/rp-smahalf of that findingis moot as written. That half was also the uncertain one — the manuals
document a screw terminal without naming the standard, and the finding says
"most likely" — so it needed evidence this PR does not have either way.
2-pinIEC C18 vs C8 collapse software: update Pro-C 3 #82 also raises is untouched. The recordedvalue is right, as the finding says; distinguishing them is a second
vocabulary decision with no wrong data behind it.
Also confirmed, no change (submissions #75).
kush-audio-ar-1carries99 USD. The store's own variant data gives
price: 9900withcompare_at_price: 9900— equal, so no sale is running and 99 is the regularprice — and
meta.jsonconfirms the store currency is USD. The refresh tookthe right direction.
Type of Change
Checklist
pnpm validateand it passeshpI added or changed names its source in the descriptionpnpm validateexits 0 at an unchanged 399 warnings (both the old and newvalues are known, so neither raises one),
prettier --checkpasses on everychanged file, and the unit suite is 35 files / 687 tests green.
Additional Notes
Source reads used the project's own
AureoCatalogBot/1.0User-Agent.🤖 Generated with Claude Code
https://claude.ai/code/session_01CNZwSZ1xLP7uxJgVTnNuFf
Generated by Claude Code
Summary by CodeRabbit
Data Updates
Documentation