Skip to content

fix(data): name the Marantz FM antenna connector, fix an archive url - #908

Merged
jeffreylouden merged 2 commits into
mainfrom
claude/eloquent-brahmagupta-fsmruh
Sep 19, 2026
Merged

jeffreylouden merged 2 commits into
mainfrom
claude/eloquent-brahmagupta-fsmruh

Conversation

@jeffreylouden

@jeffreylouden jeffreylouden commented Sep 19, 2026

Copy link
Copy Markdown
Member

Description

Settles two more catalog-submissions findings, plus one confirmed with no
change needed.

FM antenna connector (submissions #82, the evidenced half). Five Marantz
entries recorded their FM antenna jack as connection: proprietary, which
asserts the connector has no standard name. It has one — the threaded 75 ohm
coaxial F connector — read off the NR1711's own rear-panel photograph
(chrome threaded stud, centre socket, silkscreened FM 75 ohm) and confirmed per
model by the F-plug on the supplied indoor antenna in each owner's manual's
accessories figure. f-type joins schema/io-connections.yaml, which the repo
states is meant to grow when an import surfaces a legitimate new value.

Deliberately not bnc: that is a bayonet connector, not a threaded one.

Entry Was Now
marantz-nr1711 proprietary f-type
marantz-sr6015 proprietary f-type
marantz-sr7015 proprietary f-type
marantz-cinema-30 proprietary f-type
marantz-av8805a proprietary f-type

The last two are not named in the finding. A catalog-wide survey of FM antenna
ports found them carrying the identical port name under the identical wrong
value, so fixing three of five would have left the vocabulary addition
half-applied on its own maker. The two bnc hits that survey returned are
MADI and word-clock ports on RME interfaces, correctly BNC; two Tascam FM
antennas read built-in, a different maker with no evidence here, so both are
left alone.

Archive url (submissions #81). marantz-m-cr612's url pointed at
/en-us/product/network-audio-players/…, which answers 200 only by way of a
301 to /en-us/product/archive-network-audio-players/…. Verified both legs;
the archive path serves 200 directly. Marantz moves a product's path rather
than its id when it archives one. A sweep of every discontinued Marantz entry
found M-CR612 was the only one still carrying a pre-archive path.

Two corrections to the findings themselves

  • software: update Pro-C 3 #82 says nine ports carry proprietary; three did. The six Bluetooth and
    Wi-Fi antenna mounts it describes are not in the catalog as io entries at
    all, so there is nothing to retype and the sma/rp-sma half of that finding
    is moot as written. That half was also the uncertain one — the manuals
    document a screw terminal without naming the standard, and the finding says
    "most likely" — so it needed evidence this PR does not have either way.
  • The 2-pin IEC C18 vs C8 collapse software: update Pro-C 3 #82 also raises is untouched. The recorded
    value is right, as the finding says; distinguishing them is a second
    vocabulary decision with no wrong data behind it.

Also confirmed, no change (submissions #75). kush-audio-ar-1 carries
99 USD. The store's own variant data gives price: 9900 with
compare_at_price: 9900 — equal, so no sale is running and 99 is the regular
price — and meta.json confirms the store currency is USD. The refresh took
the right direction.

Type of Change

  • New software/plugin entry
  • New hardware entry
  • New manufacturer entry
  • Update to existing entry
  • Bug fix
  • Schema or script change

Checklist

  • I have run pnpm validate and it passes
  • YAML files follow the existing format
  • Manufacturer exists (or I'm adding it in this PR)
  • Categories and formats are from the schema files
  • Identifiers are accurate, if provided (bundle IDs, etc.)
  • Any hp I added or changed names its source in the description

pnpm validate exits 0 at an unchanged 399 warnings (both the old and new
values are known, so neither raises one), prettier --check passes on every
changed file, and the unit suite is 35 files / 687 tests green.

Additional Notes

Source reads used the project's own AureoCatalogBot/1.0 User-Agent.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CNZwSZ1xLP7uxJgVTnNuFf


Generated by Claude Code

Summary by CodeRabbit

  • Data Updates

    • Corrected FM antenna connection details for five Marantz products to identify the standard threaded 75-ohm F-type connector.
    • Added support for displaying F-type antenna connections in hardware specifications.
    • Updated the retired Marantz M-CR612 listing to link directly to its archived product page.
  • Documentation

    • Clarified that F-type connectors are used for FM/TV antenna and cable inputs.

The FM antenna jack is a threaded 75 ohm
coaxial F connector, not a connector without a
standard name. `f-type` joins the vocabulary and
five Marantz entries use it.

The M-CR612's url answered 200 only via a 301 to
the archive path, so it now names that path.

Settles catalog-submissions 81 and the evidenced
half of 82.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CNZwSZ1xLP7uxJgVTnNuFf
@changeset-bot

changeset-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 598e0d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
catalog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added schema Changes to catalog schemas hardware Changes to hardware catalog entries ready-for-review PR has passed all checks and is ready for review labels Sep 19, 2026
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: existential-engineering/catalog/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d0c0b030-aa66-4f18-a7bf-a9e19e946d2e

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc9753 and 598e0d6.

📒 Files selected for processing (1)
  • schema/CONTEXT.md

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


Walkthrough

The PR adds f-type as an IO connection value, updates five Marantz FM antenna declarations, and changes the M-CR612 URL to its archived product page.

Changes

Marantz metadata

Layer / File(s) Summary
FM antenna connection metadata
schema/io-connections.yaml, schema/CONTEXT.md, data/hardware/marantz-*.yaml, .changeset/marantz-antenna-and-archive-url.md
The schema and context document recognize f-type. Five Marantz products now use f-type for FM antenna inputs. The changeset records these updates.
Archived product URL
data/hardware/marantz-m-cr612.yaml
The M-CR612 URL now points to the archived product page.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: updating Marantz FM antenna connector data and correcting an archive URL. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

`schema/CONTEXT.md` is generated from the schema
files, so adding a connection value without
regenerating it fails the validate job's
up-to-date check.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CNZwSZ1xLP7uxJgVTnNuFf
@jeffreylouden
jeffreylouden merged commit d4a2c9b into main Sep 19, 2026
12 checks passed
@jeffreylouden
jeffreylouden deleted the claude/eloquent-brahmagupta-fsmruh branch September 19, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware Changes to hardware catalog entries ready-for-review PR has passed all checks and is ready for review schema Changes to catalog schemas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants