Skip to content

storage(lifecycle): use RegisterCLICommand pattern#855

Open
natalie-o-perret wants to merge 1 commit into
sc-184182/bucket-lifecyclefrom
natalie-o-perret/lifecycle-struct-pattern
Open

storage(lifecycle): use RegisterCLICommand pattern#855
natalie-o-perret wants to merge 1 commit into
sc-184182/bucket-lifecyclefrom
natalie-o-perret/lifecycle-struct-pattern

Conversation

@natalie-o-perret

@natalie-o-perret natalie-o-perret commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Rewrites the lifecycle commands to use the struct-based RegisterCLICommand pattern, consistent with newer commands like cmd/aiservices/deployment/.

Changes:

  • set, show, delete converted to typed structs with RegisterCLICommand
  • Parent command simplified (redundant zone flag and helper func removed)

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block, and add the Pull Request #number for each bit you add to the CHANGELOG.md)
  • Testing

Testing

Build and full test suite pass (make build && make test-verbose). Lint clean.

@natalie-o-perret natalie-o-perret requested a review from a team July 1, 2026 13:57
@natalie-o-perret natalie-o-perret marked this pull request as draft July 1, 2026 14:01
@natalie-o-perret

Copy link
Copy Markdown
Contributor Author

[SC-187336]

@natalie-o-perret natalie-o-perret changed the title storage(lifecycle): use RegisterCLICommand pattern + add AGENTS.md storage(lifecycle): use RegisterCLICommand pattern Jul 1, 2026
@natalie-o-perret natalie-o-perret force-pushed the natalie-o-perret/lifecycle-struct-pattern branch from 8a6f696 to 52f758e Compare July 1, 2026 14:20
@natalie-o-perret natalie-o-perret marked this pull request as ready for review July 1, 2026 14:21

@quentinalbertone quentinalbertone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea ! Do you think that you can move the storage_bucket_lifecycle* into a subpackage ? You can find an example in the aiservices package

@natalie-o-perret

natalie-o-perret commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

good idea ! Do you think that you can move the storage_bucket_lifecycle* into a subpackage ? You can find an example in the aiservices package

I've just signed off, 🚇-typing, but the idea is that we can drive the people using "AI" for external contributions with the AGENTS.md, (#856) file sitting now at the root of the repo.

Ironically-speaking, I precisely gave the AI services as an example to develop rule for the LLM to grasp the structure / pattern, and it didn't pick it on its own 😂, I will further adjust the rules there so that next time it picks it up.

Good catch anyway, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants