Prepare gem for RubyGems release with CHANGELOG and release docs - v0.2.0#5
Merged
Conversation
julioalucero
commented
Jul 16, 2026
|
|
||
| spec.add_dependency "jekyll", '~> 4.0', '>= 4.0.1' | ||
| spec.add_runtime_dependency 'nokogiri', '~> 1.8', '>= 1.8.5' | ||
| spec.add_dependency 'nokogiri', '~> 1.8', '>= 1.8.5' |
Member
Author
There was a problem hiding this comment.
add_runtime_dependency is obsolete
etagwerker
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket
FR-740: Fix nofollow on internal links
(There is no ticket, using FR-740 branches, but I'm open to do it in a a new one)
PR description
Sets up the gem for publishing to RubyGems, ensuring proper version tracking.
CHANGELOG.mdfollowing the next_rails format, withv0.2.0andv0.1.0history.github:to a plain RubyGemsgem '...'.changelog_uriat the actualCHANGELOG.md.spec.files: shippedMIT-LICENSE(doesn't exist, instead file isLICENSE.txt), so the gem was packaged with no license, also addCHANGELOG.mdadd_runtime_dependencywithadd_dependency.Test suite
This gem has no test suite. I opened PR #6 with one, but heads up: I used AI to write it (then reviewed it) to save time, since building it by hand wasn't scoped or approved for this work.
I'm totally fine writing it manually with less AI, it just needs the time/effort approval. So treat PR #6 as optional: if we don't like it, or it'd take too long to get right, we can just close it and do it properly later.
QA steps
gem build jekyll-external-link-accessibility.gemspec=> should build with no warnings.tag 'v0.2.0',push tags, thengem push