add missing_only=True to all imputers to use in combination with variables=None - #974
Open
ojassharma7 wants to merge 2 commits into
Open
add missing_only=True to all imputers to use in combination with variables=None#974ojassharma7 wants to merge 2 commits into
ojassharma7 wants to merge 2 commits into
Conversation
The imputers import feature_engine._docstrings.init_parameters.imputers, but the new file was left untracked so CircleCI failed on import. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
Hi @ojassharma7 I am making a full migration from pandas to narwahls to support polars and pyarrow as well. So before we expand the functionality of the transformers, I need to complete that migration first. I'll keep this one on hold for now. I'd be happy to have your support on issues related to that migration. You'll find it in #965. We need to update each module to support narwahls instead of the current pandas logic in the fit transform functionality. 1 PR per module. Before choosing what to work on, leave a comment on the main PR, or check that no other PR is open already for that module, not to duplicate work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388.
What changed
feature_engine/imputation/arbitrary_number.pyfeature_engine/imputation/base_imputer.pyfeature_engine/imputation/categorical.pyfeature_engine/imputation/end_tail.pyfeature_engine/imputation/mean_median.pyfeature_engine/imputation/random_sample.pytests/test_imputation/test_arbitrary_number_imputer.pytests/test_imputation/test_categorical_imputer.pytests/test_imputation/test_end_tail_imputer.pytests/test_imputation/test_mean_median_imputer.pytests/test_imputation/test_random_sample_imputer.pyVerification
The project's own test suite was run before and after this change; it introduces no new test failures or lint violations.