Skip to content

fix(cli): --version works for pip installs (importlib.metadata) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wized2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): --version works for pip installs (importlib.metadata) #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions insight/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@
from .reporter import generate_report

def get_version():
"""Resolve package version without requiring setup.py on disk (pip installs)."""
try:
from importlib.metadata import version as pkg_version
return pkg_version("insight-cli-sarang")
except Exception:
pass
try:
from importlib.metadata import version as pkg_version
return pkg_version("insight")
except Exception:
pass
try:
from . import __version__
return __version__
Expand All @@ -15,8 +26,8 @@ def get_version():
setup_py = here / "setup.py"
if setup_py.exists():
with open(setup_py, "r") as f:
content = f.read()
match = re.search(r"version=\"(.*?)\"", content)
text = f.read()
match = re.search(r'version\s*=\s*["\'](.*?)["\']', text)
if match:
return match.group(1)
return "0.2.6"
Expand All @@ -38,6 +49,7 @@ def main():
analysis = analyze_codebase(args.path, limit=args.limit)

print("Generating reports...")

generate_report(analysis, args.output)

print(f"Reports saved in {args.output}/")
Expand Down