Skip to content

Fix: CustomQuantity with immobile Species - #1212

Merged
RemDelaporteMathurin merged 4 commits into
mainfrom
fix-custom-immobile
Jul 27, 2026
Merged

Fix: CustomQuantity with immobile Species#1212
RemDelaporteMathurin merged 4 commits into
mainfrom
fix-custom-immobile

Conversation

@RemDelaporteMathurin

@RemDelaporteMathurin RemDelaporteMathurin commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Summary

This PR makes sure we only fetch D_global for species that are mobile to avoid raising a KeyError

Related Issues

Fixes #1211

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.19%. Comparing base (71e8781) to head (080867a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          53       53           
  Lines        3951     3952    +1     
=======================================
+ Hits         3761     3762    +1     
  Misses        190      190           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin RemDelaporteMathurin added the bug Something isn't working label Jul 27, 2026
@RemDelaporteMathurin
RemDelaporteMathurin merged commit f4d052c into main Jul 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug CustomQuantity with immobile species

1 participant