docs(kits): document differences from the legacy extensions - #2948
Open
IzaakGough wants to merge 1 commit into
Open
docs(kits): document differences from the legacy extensions#2948IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
Each kit's README gains a "Differences from the <extension> extension" section covering the migration traps, behavioural changes and missing tooling a user moving off an installed instance needs to know. The changelog entry now points at it. firestore-incremental-capture is untouched: it is a private, unimplemented skeleton package with nothing to compare against.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md and README.md files across multiple Firebase kits, including bigquery-firestore-export, delete-user-data, firestore-bigquery-export, firestore-bundle-builder, firestore-counter, firestore-genai-chatbot, firestore-send-email, firestore-translate-text, firestore-vector-search, rtdb-limit-child-nodes, speech-to-text, and storage-resize-images. The updates introduce a comprehensive 'Differences' section in each README to guide users migrating from the legacy Firebase Extensions to these repackaged npm packages, detailing changes in configuration, runtime behavior, and deployment regions. As there are no review comments provided, I have no feedback to offer.
IzaakGough
marked this pull request as ready for review
August 18, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every kit's changelog said only "Initial release", and nothing told a user moving off an installed extension instance what would behave differently.
Each kit README gains a
## Differences from the <extension> extensionsection, and the changelog entry points at it. Twelve kits are covered.firestore-incremental-captureis untouched: this kit is still in the process of being implemented and tested.Each section covers only what a migrating user acts on: settings renamed or newly defaulted, install-time validation that now fails at runtime, secrets that must exist by name, region and generation changes, data shape changes, and tooling that did not come across. Shared template differences (
extension.yamlto npm package, params,HandlerContext, gen1 to gen2 boilerplate) are deliberately left out.Verified by reading the extension and kit source for each pair, plus the
extension.yamlparams. Nothing was exercised against a live deploy, and each section says so where a claim depends on one.Two decisions for a reviewer: whether the section belongs before
## API surface, where it is now, or higher up in each README; and whether to leave thefirestore-incremental-capturechangelog as it is.