Skip to content

Set up kits for correct publishing info - #2953

Open
inlined wants to merge 2 commits into
firebase:kitsfrom
inlined:update-kits-publish-config
Open

Set up kits for correct publishing info#2953
inlined wants to merge 2 commits into
firebase:kitsfrom
inlined:update-kits-publish-config

Conversation

@inlined

@inlined inlined commented Aug 18, 2026

Copy link
Copy Markdown
Member

Updates all kits package.json files to set private: false and configures publishConfig.registry to https://wombat-dressing-room.appspot.com.

@inlined
inlined requested a review from a team as a code owner August 18, 2026 19:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures various package.json files across multiple kits for public publishing by adding "private": false and specifying the publishConfig registry. However, the "private": false field was missed in kits/bigquery-firestore-export/package.json, which is inconsistent with the other packages.

Comment on lines +43 to 46
"publishConfig": {
"access": "public",
"registry": "https://wombat-dressing-room.appspot.com"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This package.json is missing the "private": false field, which is inconsistent with the other kits and the PR description.

  "private": false,
  "publishConfig": {
    "access": "public",
    "registry": "https://wombat-dressing-room.appspot.com"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants