[bar-reloc 5/12] pci: Pass the BAR address to set_notification_ioevents() - #6090
Merged
Conversation
ilstam
changed the title
ilstam
marked this pull request as ready for review
August 7, 2026 15:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
=======================================
Coverage 82.93% 82.93%
=======================================
Files 276 276
Lines 30846 30850 +4
=======================================
+ Hits 25582 25586 +4
Misses 5264 5264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 10, 2026 17:58
360ff13 to
a677992
Compare
ShadowCurse
previously approved these changes
Aug 11, 2026
Manciukic
previously approved these changes
Aug 12, 2026
Contributor
|
It looks like CI is failing at this PR in the stack: |
Contributor
Author
Flaky failure? It passed after re-running. |
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 14, 2026 16:49
a677992 to
fcbc0f8
Compare
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 14, 2026 16:49
fcbc0f8 to
0683e42
Compare
ilstam
changed the title
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 17, 2026 10:23
0683e42 to
1889637
Compare
Contributor
Can we please track these failures internally? We can't have flaky failures accumulate with nobody fixing them. The CI failed on a different flake now... |
Manciukic
approved these changes
Aug 18, 2026
Contributor
Author
I have created internal tracking tickets for all of them. |
ShadowCurse
approved these changes
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 18, 2026
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 18, 2026 17:21
1889637 to
6ffebd1
Compare
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 18, 2026
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 18, 2026 19:30
6ffebd1 to
e227ab8
Compare
Make set_notification_ioevents take the BAR base address as an argument instead of reading it from config_bar_addr() itself. This will be needed in subsequent commits where the BAR address stored in the config space doesn't necessarily match the address used when ioeventfds were registered (during BAR relocation). No functional change intended. PR: #6090 Signed-off-by: Ilias Stamatis <ilstam@amazon.com>
ilstam
force-pushed
the
ilstam/bar-reloc-04-pass-bar-address
branch
from
August 18, 2026 21:04
e227ab8 to
be7211d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make set_notification_ioevents take the BAR base address as an argument
instead of reading it from config_bar_addr() itself. This will be needed
in subsequent commits where the BAR address stored in the config space
doesn't necessarily match the address used when ioeventfds were
registered (during BAR relocation).
No functional change intended.
Signed-off-by: Ilias Stamatis ilstam@amazon.com