Deduplicate the frameTable during compaction#6017
Open
mstange wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6017 +/- ##
==========================================
+ Coverage 83.50% 83.52% +0.01%
==========================================
Files 342 342
Lines 36183 36261 +78
Branches 10133 10141 +8
==========================================
+ Hits 30216 30288 +72
- Misses 5539 5545 +6
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
68942f5 to
f971d3f
Compare
607ffd5 to
31fb186
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main branch | Deploy preview
When we combine the per-thread frame tables from the gecko profile format into the shared frame table of the processed format, we don't do any deduplication, because deduplicating would slow down loading. But we could do it during profile compacting (after sanitization) instead. This will also make it work for profiles captured from older samply versions, or when re-uploading old shared profiles.
In the profiles linked above, if I re-upload with the "Screenshots" checkbox unchecked (so that sanitization runs profile compacting), I get the following numbers:
This PR doesn't implement stack table deduplication; I expect some more savings from that, but it needs frame table deduplication first. Edit: Implemented in #6137, doesn't actually save much.