Make crypto provider agnostic#68
Open
ameba23 wants to merge 4 commits into
Open
Conversation
* main: Fmt Comments Rm QemuTdx attestation type as it effectively is the same as DcapTdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A design goal for the library crates is to let users of the library choose which crypto provider they want to use. (aws-lc-rs or ring)
Previously this was the case but some recent changes when bumping reqwest version broke this, and i didn't notice until bumping the attestation crate used by attested-tls-proxy.
This PR moves back to being crypto provider agnostic, and uses aws-lc-rs in tests and for the attestation-provider-server binary crate.
Paired PR: flashbots/attested-tls-proxy#168