Remove QemuTdx attestation type#69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AttestationTypeenum variants were ported over fromcvm-reverse-proxyto maintain compatibility with JSON measurements format and HTTP header format.There are two types which are effectively treated the same: DcapTdx and QemuTdx. Both assume DCAP attestation format and do not specify a particular cloud provider.
This creates ambiguity when converting to/from
attest_types::AttestationType, which has an equivalentSelfHostedTdxtype. Converting one to the other and then back behaves inconsistently.Eventually we will probably adopt the type from
attest_types. But until then this PR removes theQemuTdxvariant, and interpretsqemu-tdxasDcapTdxif used in the measurements JSON data structure, to preserve backwards compatibility.