Fix dynamic request resolution#226
Draft
roncodes wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Find::httpRequestForModel()built action-specific request class names by appending an extra namespace separator even though the request namespace already ended with one. That produced malformed class names such as...\Http\Requests\\UpdateAssetRequest, causing class lookup to fail and validation to fall back to the generic Fleetbase request.Validation
./vendor/bin/pest tests/Unit/FindHttpRequestForModelTest.php --colors=always./vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php --dry-run --diff src/Support/Find.php tests/Unit/FindHttpRequestForModelTest.php tests/Fixtures/Models/AssetValidationRecord.php tests/Fixtures/Models/MissingRequestRecord.php tests/Fixtures/Http/Requests/CreateAssetValidationRecordRequest.php tests/Fixtures/Http/Requests/UpdateAssetValidationRecordRequest.phpcomposer test:unitis still blocked by the existing missingTests\TestCaseissue intests/Unit/Reporting/ComputedColumnValidatorTest.php.