[flutter_inappwebview] Fix SIGTRAP on TV app teardown - #1100
Merged
seungsoo47 merged 2 commits intoAug 25, 2026
Merged
Conversation
seungsoo47
commented
Aug 21, 2026
seungsoo47
commented
Contributor
- Fix a SIGTRAP/SIGSEGV crash during app teardown on TV targets: ewk_init()/ewk_shutdown() were both commented out, but chromium-efl requires them to be called exactly once per process.
- Add WebView::InitializeEngine()/ShutdownEngine(), called from the plugin's constructor/destructor. ShutdownEngine() waits (bounded, 2s) for all WebView instances to be disposed first, since ewk_shutdown() fatally CHECKs if any Ewk_View is still alive.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4211a8498d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ewk_init() and ewk_shutdown() were both commented out, guessing that OS-level EFL init and SetArguments() made ewk_init() unnecessary. In practice chromium-efl needs ewk_init()/ewk_shutdown() called exactly once per process: without ewk_init(), some engine state assumed initialized elsewhere is never set up, and on TV targets this surfaces as a SIGTRAP/SIGSEGV during app teardown. Call ewk_init() once from the plugin's constructor and ewk_shutdown() once from its destructor, via new WebView::InitializeEngine()/ShutdownEngine() static helpers. ShutdownEngine() waits (bounded, 2s) for the live WebView instance set to drain first, since ewk_shutdown() fatally CHECKs if any Ewk_View is still alive; normal teardown order (platform views destroyed before the plugin) already guarantees this, so the wait is defensive only. Verified with 3 clean drive runs each on the TV emulator and a real TV device, with no crash and no crash dumps.
seungsoo47
force-pushed
the
flutter_inappwebview-tv-shutdown-fix2
branch
from
August 25, 2026 06:39
4211a84 to
556a9f1
Compare
JSUYA
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.