[device_info_plus] Add duid getter - #1106
Merged
Merged
Conversation
Add DeviceInfoPluginTizen.duid to read the device's DUID via vconf.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a569b092b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Fixes a PR review comment: caching the resolved value meant a null DUID never got cached, so every call re-triggered the native lookup.
JSUYA
reviewed
Aug 26, 2026
JSUYA
reviewed
Aug 26, 2026
GetDuid() now returns an empty string, not null, when the device isn't running the TV profile, since that is a permanent property of the device rather than a failure. null is reserved for a genuine vconf/dlopen read failure, which may be transient and worth retrying. This lets the duid getter cache with the same simple `??=` pattern as tizenInfo: a confirmed-empty (non-TV) result is now cached permanently, while a real failure keeps retrying on the next access instead of being stuck as a cached null forever. Also drops a leftover debug log line and updates the README table and integration test to match.
JSUYA
reviewed
Aug 26, 2026
- Remove a leftover debug log line in GetDuid() that should have been dropped in the previous commit. - Switch the TV-profile check from a runtime system_info call to the TV_PROFILE compile-time macro, matching the convention already used by camera, video_player, webview_flutter, webview_flutter_lwe, and flutter_inappwebview. flutter-tizen defines this macro from the target device's actual profile for both build and drive/run, so behavior is unchanged. - Add explanatory comments to the duid caching test mirroring the existing tizenInfo test, clarifying that a new plugin instance triggers a fresh native call rather than reusing the cache.
JSUYA
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DeviceInfoPluginTizen.duid to read the device's DUID via vconf. This is a Tizen-specific API with no upstream counterpart in device_info_plus.