-
Notifications
You must be signed in to change notification settings - Fork 170
Add flutter-app-runtime rule for proactive hot reload #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jwren
wants to merge
1
commit into
main
Choose a base branch
from
rule-flutter-app-runtime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−19
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| description: Proactively connect to running Dart/Flutter apps and trigger hot reload using the flutter-app-runtime skill workflows upon editing .dart files. | ||
| globs: "**/*.dart" | ||
| --- | ||
|
|
||
| # Proactive Flutter Hot Reload Rule | ||
|
|
||
| Whenever you edit or modify any `.dart` file in this project, adhere to the runtime management procedures in the `flutter-app-runtime` skill: | ||
|
|
||
| 1. **Refer to Skill**: | ||
| - Activate and follow the `flutter-app-runtime` skill workflows for Dart Tooling Daemon (`dtd`), hot reloading, hot restarting, and runtime error inspection. | ||
|
Comment on lines
+8
to
+11
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| 2. **Discover & Connect**: | ||
| - Discover active running application instances using the `dtd` tool (or `list_running_apps` / `vm_service`). | ||
|
|
||
| 3. **Trigger Hot Reload / Hot Restart**: | ||
| - Execute `hot_reload` immediately after making changes to UI widgets or simple methods. | ||
| - Execute `hot_restart` if fundamental logic, state initialization, or `main()` was modified. | ||
|
|
||
| 4. **Verify Runtime Stability**: | ||
| - Run `get_runtime_errors` via `dart-mcp-server` to confirm that the hot reload/restart did not introduce new exceptions. | ||
|
|
||
| 5. **Fallback Handling**: | ||
| - If no running app instance is connected via DTD, briefly inform the user, but do not let it stop you from completing the code edits. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| description: Proactively connect to running Dart/Flutter apps and trigger hot reload using the flutter-app-runtime skill workflows upon editing .dart files. | ||
| globs: "**/*.dart" | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| # Proactive Flutter Hot Reload Rule | ||
|
|
||
| Whenever you edit or modify any `.dart` file in this project, adhere to the runtime management procedures in the `flutter-app-runtime` skill: | ||
|
|
||
| 1. **Refer to Skill**: | ||
| - Activate and follow the `flutter-app-runtime` skill workflows for Dart Tooling Daemon (`dtd`), hot reloading, hot restarting, and runtime error inspection. | ||
|
Comment on lines
+9
to
+12
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| 2. **Discover & Connect**: | ||
| - Discover active running application instances using the `dtd` tool (or `list_running_apps` / `vm_service`). | ||
|
|
||
| 3. **Trigger Hot Reload / Hot Restart**: | ||
| - Execute `hot_reload` immediately after making changes to UI widgets or simple methods. | ||
| - Execute `hot_restart` if fundamental logic, state initialization, or `main()` was modified. | ||
|
|
||
| 4. **Verify Runtime Stability**: | ||
| - Run `get_runtime_errors` via `dart-mcp-server` to confirm that the hot reload/restart did not introduce new exceptions. | ||
|
|
||
| 5. **Fallback Handling**: | ||
| - If no running app instance is connected via DTD, briefly inform the user, but do not let it stop you from completing the code edits. | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous rule file
rules/hot_reload.mdincludedtrigger: globin its frontmatter. If the rule parser requires this field to trigger the rule on glob matches, it should be retained in the newrules/flutter-app-runtime.mdfile.