Skip to content

[webview_flutter_wkwebview] Regenerate with pigeon 29.0.2 - #12923

Open
Xelorium wants to merge 1 commit into
flutter:mainfrom
Xelorium:wkwebview-regenerate-pigeon-29
Open

Xelorium wants to merge 1 commit into
flutter:mainfrom
Xelorium:wkwebview-regenerate-pigeon-29

Conversation

@Xelorium

@Xelorium Xelorium commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Regenerates webview_flutter_wkwebview with pigeon 29.0.2, which contains the Swift generator fix from #12531.

The generated WKNavigationDelegate.didReceiveAuthenticationChallenge reply handler now treats NSNull as a null reply, so a response the native PigeonInstanceManager can no longer resolve reports a null-error instead of force-casting and aborting the process:

Could not cast value of type 'NSNull' (0x...) to 'webview_flutter_wkwebview.AuthenticationChallengeResponse' (0x...).

The diff is large because the package was last generated with 27.3.2, so it also picks up the 28.x/29.x generator changes; no hand-written code needed updating.

Verification

  • flutter analyze is clean.
  • All 154 unit tests pass.
  • The iOS example builds for the simulator.
  • The NSNull check is present at the AuthenticationChallengeResponse call site in the regenerated WebKitLibrary.g.swift.

Fixes flutter/flutter#191254

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@google-cla

google-cla Bot commented Sep 18, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the webview_flutter_wkwebview package version to 3.26.2 and upgrades the pigeon dependency to ^29.0.2 to resolve a crash related to WKNavigationDelegate authentication challenges. I have no feedback to provide as there were no review comments.

Picks up the Swift generator fix from
flutter#12531, so a
`WKNavigationDelegate.didReceiveAuthenticationChallenge` reply that the
native instance manager can no longer resolve reports a `null-error`
instead of force-casting `NSNull` and aborting the process.
@Xelorium
Xelorium force-pushed the wkwebview-regenerate-pigeon-29 branch from 067c93e to 59f9168 Compare September 18, 2026 05:31
@bparrishMines bparrishMines added the CICD Run CI/CD label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants