Conversation
yazanmg
marked this pull request as ready for review
September 18, 2026 18:12
Contributor
There was a problem hiding this comment.
Code Review
This pull request restores support for SDK MaterialApp and CupertinoApp alongside material_ui and cupertino_ui packages by introducing an AppType enum to identify the closest app implementation in the widget tree and updating the builder, page builders, hero controllers, and error screens accordingly. The reviewer suggests clearing the cached _pageBuilderForAppType and _errorBuilderForAppType builders inside didChangeDependencies to ensure they are re-evaluated when context dependencies change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#192761.
go_router18.x migrated its default Material and Cupertino adapters tomaterial_uiandcupertino_ui. This left apps using the Flutter SDK'sMaterialApporCupertinoAppundetected in code paths that select default pages, hero controllers, and error screens.This change restores support for the Flutter SDK app types while preserving the existing Material-over-Cupertino adapter precedence. Within each app family, the closest supported SDK or
*_uiimplementation is used so the page, hero controller, and default error screen stay within the same UI implementation.Supported app implementations are:
MaterialAppmaterial_ui.MaterialAppCupertinoAppcupertino_ui.CupertinoAppNested-app regression tests verify that the existing Material-over-Cupertino precedence is preserved while selecting the matching SDK/
*_uiimplementation.Coverage also verifies:
material_uiMaterial pages.cupertino_uiCupertino pages.Validation completed successfully:
go_routertest suite passes.Pre-Review Checklist