[url_launcher] Fix supportsCloseForLaunchMode to query close support - #12926
Open
NikhilKukreja26 wants to merge 5 commits into
Open
NikhilKukreja26 wants to merge 5 commits into
NikhilKukreja26 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates supportsCloseForLaunchMode to correctly query supportsCloseForMode on the platform instead of supportsMode, alongside a version bump to 6.3.3 and a new regression test. Feedback recommends allowing setCloseForModeResponse to accept a nullable bool? and adding a tearDown block to reset the mock state, ensuring proper test isolation and preventing test pollution.
stuartmorgan-g
requested changes
Sep 18, 2026
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution!
Author
|
Thanks for the review! Addressed all points — fresh mock via setUp, removed the fallback and nullable setter, and trimmed the CHANGELOG. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#192758
supportsCloseForLaunchModewas callingUrlLauncherPlatform.supportsMode(the launch-support check) instead of
supportsCloseForMode, so it reportedwhether a mode can be launched rather than whether an in-app web view opened
with that mode can be closed. This changes it to call
supportsCloseForMode,and adds a regression test (the shared mock is extended so the two platform
methods can return different values).
Pre-launch Checklist
///).