Skip to content

[Material_ui] Make locales constants in time_picker_test.dart #12947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AbdeMohlbi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Material_ui] Make locales constants in time_picker_test.dart #12947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/material_ui/pending_changelogs/change_2026_09_19_1789832369330.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog: |
- update timePicker i10n tests to use constant locales
version: patch
84 changes: 42 additions & 42 deletions packages/material_ui/test/l10n/time_picker_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ void main() {
);

// TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them
final locales = <Locale>[
const Locale('en', 'US'), //'h:mm a'
const Locale('en', 'GB'), //'HH:mm'
const Locale('es', 'ES'), //'H:mm'
const Locale('fr', 'CA'), //'HH \'h\' mm'
const Locale('zh', 'ZH'), //'ah:mm'
const Locale('fa', 'IR'), //'H:mm' but RTL
const locales = <Locale>[
Locale('en', 'US'), //'h:mm a'
Locale('en', 'GB'), //'HH:mm'
Locale('es', 'ES'), //'H:mm'
Locale('fr', 'CA'), //'HH \'h\' mm'
Locale('zh', 'ZH'), //'ah:mm'
Locale('fa', 'IR'), //'H:mm' but RTL
];

for (final locale in locales) {
Expand Down Expand Up @@ -121,13 +121,13 @@ void main() {
);

// TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them
final locales = <Locale>[
const Locale('en', 'US'), //'h:mm a'
const Locale('en', 'GB'), //'HH:mm'
const Locale('es', 'ES'), //'H:mm'
const Locale('fr', 'CA'), //'HH \'h\' mm'
const Locale('zh', 'ZH'), //'ah:mm'
const Locale('fa', 'IR'), //'H:mm' but RTL
const locales = <Locale>[
Locale('en', 'US'), //'h:mm a'
Locale('en', 'GB'), //'HH:mm'
Locale('es', 'ES'), //'H:mm'
Locale('fr', 'CA'), //'HH \'h\' mm'
Locale('zh', 'ZH'), //'ah:mm'
Locale('fa', 'IR'), //'H:mm' but RTL
];

for (final locale in locales) {
Expand Down Expand Up @@ -201,13 +201,13 @@ void main() {
);

// TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them
final locales = <Locale>[
const Locale('en', 'US'), //'h:mm a'
const Locale('en', 'GB'), //'HH:mm'
const Locale('es', 'ES'), //'H:mm'
const Locale('fr', 'CA'), //'HH \'h\' mm'
const Locale('zh', 'ZH'), //'ah:mm'
const Locale('fa', 'IR'), //'H:mm' but RTL
const locales = <Locale>[
Locale('en', 'US'), //'h:mm a'
Locale('en', 'GB'), //'HH:mm'
Locale('es', 'ES'), //'H:mm'
Locale('fr', 'CA'), //'HH \'h\' mm'
Locale('zh', 'ZH'), //'ah:mm'
Locale('fa', 'IR'), //'H:mm' but RTL
];

for (final locale in locales) {
Expand Down Expand Up @@ -291,13 +291,13 @@ void main() {
);

// TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them
final locales = <Locale>[
const Locale('en', 'US'), //'h:mm a'
const Locale('en', 'GB'), //'HH:mm'
const Locale('es', 'ES'), //'H:mm'
const Locale('fr', 'CA'), //'HH \'h\' mm'
const Locale('zh', 'ZH'), //'ah:mm'
const Locale('fa', 'IR'), //'H:mm' but RTL
const locales = <Locale>[
Locale('en', 'US'), //'h:mm a'
Locale('en', 'GB'), //'HH:mm'
Locale('es', 'ES'), //'H:mm'
Locale('fr', 'CA'), //'HH \'h\' mm'
Locale('zh', 'ZH'), //'ah:mm'
Locale('fa', 'IR'), //'H:mm' but RTL
];

for (final locale in locales) {
Expand Down Expand Up @@ -371,13 +371,13 @@ void main() {
.first;

// TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them
final locales = <Locale>[
const Locale('en', 'US'), //'h:mm a'
const Locale('en', 'GB'), //'HH:mm'
const Locale('es', 'ES'), //'H:mm'
const Locale('fr', 'CA'), //'HH \'h\' mm'
const Locale('zh', 'ZH'), //'ah:mm'
const Locale('fa', 'IR'), //'H:mm' but RTL
const locales = <Locale>[
Locale('en', 'US'), //'h:mm a'
Locale('en', 'GB'), //'HH:mm'
Locale('es', 'ES'), //'H:mm'
Locale('fr', 'CA'), //'HH \'h\' mm'
Locale('zh', 'ZH'), //'ah:mm'
Locale('fa', 'IR'), //'H:mm' but RTL
];

for (final locale in locales) {
Expand Down Expand Up @@ -456,13 +456,13 @@ void main() {
.first;

// TODO(yjbanov): also test `HH.mm` (in_ID), `a h:mm` (ko_KR) and `HH:mm น.` (th_TH) when we have .arb files for them
final locales = <Locale>[
const Locale('en', 'US'), //'h:mm a'
const Locale('en', 'GB'), //'HH:mm'
const Locale('es', 'ES'), //'H:mm'
const Locale('fr', 'CA'), //'HH \'h\' mm'
const Locale('zh', 'ZH'), //'ah:mm'
const Locale('fa', 'IR'), //'H:mm' but RTL
const locales = <Locale>[
Locale('en', 'US'), //'h:mm a'
Locale('en', 'GB'), //'HH:mm'
Locale('es', 'ES'), //'H:mm'
Locale('fr', 'CA'), //'HH \'h\' mm'
Locale('zh', 'ZH'), //'ah:mm'
Locale('fa', 'IR'), //'H:mm' but RTL
];

for (final locale in locales) {
Expand Down
Loading