Skip to content

Clean up packages and cocoon tests - #494

Open
Piinks wants to merge 1 commit into
flutter:mainfrom
Piinks:addMCtests
Open

Piinks wants to merge 1 commit into
flutter:mainfrom
Piinks:addMCtests

Conversation

@Piinks

@Piinks Piinks commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g

Copy link
Copy Markdown

That shard only runs analyze. The customer tests run actual tests from several packages, so this will remove coverage.

If you just want to remove the duplicate analysis, you'd need to remove the analyze steps from the customer test script in the packages repo, rather that removing the entire customer testing call.

@Piinks

Piinks commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

That shard only runs analyze. The customer tests run actual tests from several packages, so this will remove coverage.

If you just want to remove the duplicate analysis, you'd need to remove the analyze steps from the customer test script in the packages repo, rather that removing the entire customer testing call.

Ah ha! Ok that answers a question I had about whether or not material_ui and cupertino_ui tests were running in presubmit in flutter/flutter already. Sounds like no, since the test hash here is 6 months old, and the luci build is only for analyze. Ok cool. I will update this to just update the hash rather than remove altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants