Conversation
Compare artifact digests as well as revisions when mapping source updates to Kustomizations. Add regression tests for applying changed content while the source Git revision remains unchanged. Assisted-by: Hermes Agent (gpt-6-astra / openai-codex) Signed-off-by: Michael Basov <124149774+banlor@users.noreply.github.com>
Author
|
@matheuscscp could you take a look? |
Member
|
You should use the ArtifactGenerator CRD for that at this point, we will not evolve other artifact-processing features outside this CRD |
Author
|
Got it, thanks. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to fluxcd/source-controller#522.
An included GitRepository can produce different artifact contents while keeping the same Git revision. The source update predicate notices this, but requestsForRevisionChange drops it because lastAttemptedRevision already matches.
Keep the mapper's shortcut only when both revision and digest are unchanged. The envtest regression applies changed ConfigMap content without advancing the Git revision, and covers unchanged-digest and timestamp-only updates.
The full make test passed on Go 1.26.8 and Kubernetes 1.37.0 (330 tests and subtests). The separate API-module check also passed; those packages have no tests.
An extra full race run is not green. The kyaml ResetOpenAPI/getSchema race also reproduces on the unchanged base. Another report involves the prune test swapping the shared reconciler client; that test and getSource are unchanged, but a separate baseline retry did not reproduce that report.
Assisted by Hermes Agent with gpt-6-astra.