Skip to content

fix: remove sx prop with height from medium buttons - #1061

Open
tomrndom wants to merge 2 commits into
masterfrom
fix/button-sx-height
Open

fix: remove sx prop with height from medium buttons#1061
tomrndom wants to merge 2 commits into
masterfrom
fix/button-sx-height

Conversation

@tomrndom

@tomrndom tomrndom commented Sep 4, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bbu8dfu

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Style
    • Updated sponsor question and tier buttons to use more flexible sizing.
    • Simplified fee type dialog button styling by removing custom dimensions and typography.
    • Button labels and functionality remain unchanged.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
…ttons

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 7919ac4c-4f7e-4f1c-9464-79ce8fe48349

📥 Commits

Reviewing files that changed from the base of the PR and between d1f5855 and ee23390.

📒 Files selected for processing (3)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-general-form/extra-questions.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-general-form/sponsorship.js
  • src/pages/tickets/payment-profile/components/payment-profile-dialog.js
💤 Files with no reviewable changes (3)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-general-form/extra-questions.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-general-form/sponsorship.js
  • src/pages/tickets/payment-profile/components/payment-profile-dialog.js

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The change removes fixed height and custom typography styles from sponsor form and payment profile dialog buttons. Button labels and functional behavior remain unchanged.

Changes

Button sizing cleanup

Layer / File(s) Summary
Sponsor form button sizing
src/pages/sponsors/sponsor-page/tabs/sponsor-general-form/extra-questions.js, src/pages/sponsors/sponsor-page/tabs/sponsor-general-form/sponsorship.js
Removes the fixed 36px height from the add-question and add-tier buttons.
Payment profile button sizing
src/pages/tickets/payment-profile/components/payment-profile-dialog.js
Removes custom height, font size, line height, and letter-spacing styles from the new, cancel, and save fee type buttons.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ee233

This update lets affected sponsor and payment-profile buttons use their standard sizing and typography while preserving their labels and behavior. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing height values from the sx prop on medium buttons.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/button-sx-height

Comment @coderabbitai help to get the list of available commands.

@tomrndom tomrndom self-assigned this Sep 4, 2026
@tomrndom
tomrndom requested a review from smarcet September 4, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant