Skip to content

fix: add resend speakers checkbox on summit speakers email send popup - #1064

Open
tomrndom wants to merge 1 commit into
masterfrom
fix/resend-speakers-checkbox
Open

fix: add resend speakers checkbox on summit speakers email send popup#1064
tomrndom wants to merge 1 commit into
masterfrom
fix/resend-speakers-checkbox

Conversation

@tomrndom

@tomrndom tomrndom commented Sep 4, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bbtnft1

image

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features
    • Added an option to resend emails to speakers who have already received the message.
    • Added a confirmation checkbox for resending speaker emails, enabled by default in the speaker-email dialog.
    • Email workflows now support independently controlling speaker resends and copies to submitters.
    • Added English-language text for the resend confirmation prompt.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom self-assigned this Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 886931f5-2086-43d5-b9ee-7a93bc5f56ac

📥 Commits

Reviewing files that changed from the base of the PR and between d1f5855 and f22484d.

📒 Files selected for processing (4)
  • src/actions/speaker-actions.js
  • src/actions/submitter-actions.js
  • src/i18n/en.json
  • src/pages/summit_speakers/summit-speakers-list-page.js

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The speaker email workflow adds a resend-speakers checkbox, passes its value through the page and action layers, and includes it as should_resend in the email request. The submitter email action also accepts the new parameter.

Changes

Speaker email resend

Layer / File(s) Summary
Email action contract
src/actions/speaker-actions.js, src/actions/submitter-actions.js
The email actions accept shouldResendSpeakers. The speaker action sends it as should_resend.
Speaker email resend UI
src/pages/summit_speakers/summit-speakers-list-page.js, src/i18n/en.json
The speaker-only modal adds a default-checked resend checkbox. The selected value passes to the speaker email action with the existing submitter-copy option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f2248

The speaker email popup now lets users resend to already-contacted speakers and forwards that choice with the email request. No current merge-blocking risk is identified.

Sequence Diagram(s)

sequenceDiagram
  participant SpeakerEmailModal
  participant SummitSpeakersPage
  participant sendSpeakerEmails
  participant EmailRequest
  SpeakerEmailModal->>SummitSpeakersPage: select resend speakers
  SummitSpeakersPage->>sendSpeakerEmails: submit shouldResendSpeakers
  sendSpeakerEmails->>EmailRequest: send should_resend
Loading

Suggested reviewers: santipalenque, smarcet, romanetar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a resend speakers checkbox to the summit speakers email popup.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/resend-speakers-checkbox

Comment @coderabbitai help to get the list of available commands.

@tomrndom
tomrndom requested a review from smarcet September 4, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant