Bump required Ruby version to 2.5 - #551
Open
tas50 wants to merge 1 commit into
Open
Conversation
The fog core gem already requires Ruby >= 2.5.0, so the previous '>= 2.2.0' constraint here was never actually satisfiable for anyone installing fog-openstack alongside fog. Ruby 2.2 through 2.4 are also long past end-of-life. Align the constraint with fog core. This also raises the RuboCop TargetRubyVersion inferred from the gemspec from 2.2 to 2.5, which introduces no new offenses. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fog core gem already declares
required_ruby_version = '>= 2.5.0', so fog-openstack's'>= 2.2.0'was never actually satisfiable for anyone installing this gem alongside fog. Ruby 2.2–2.4 are also long past end-of-life.This aligns fog-openstack with fog core.
Note on RuboCop
RuboCop infers
TargetRubyVersionfrom the gemspec when.rubocop.ymldoesn't set it explicitly, so this bumps the lint target from 2.2 to 2.5. Verified the offense count is unchanged (2600 before, 2600 after), so no new cops are triggered by the bump.