Remove .travis.yml, modernize README badges, and fix stale links - #552
Merged
Conversation
CI moved to GitHub Actions some time ago (.github/workflows/ci.yml delegates to the shared fog/.github reusable workflow), so the Travis config is dead weight. Its matrix still topped out at Ruby 2.6. Also drop three README badges that no longer resolve: - Travis (travis-ci.org was decommissioned in 2021) - Gemnasium (service shut down in 2018) - Code Climate (no longer configured for this repo) The Gem Version, Coveralls, and Gitter badges are unchanged. Signed-off-by: Tim Smith <tsmith84@proton.me>
Move the surviving badges to shields.io so they share one visual style
and use currently-supported endpoints:
- Gem Version: badge.fury.io -> img.shields.io/gem/v
- Coverage: coveralls.io native badge -> img.shields.io/coverallsCoverage
- Gitter: badges.gitter.im -> img.shields.io/gitter/room
The old Coveralls badge had been rendering 'unknown'; the shields.io
endpoint reports the real 98%. The Gitter link now points at
app.gitter.im directly instead of relying on a redirect, and drops the
utm_* tracking parameters.
Also repoint every link that was dead or redirecting:
- docs directory link 404'd (lib/fog/openstack/docs -> docs)
- Neutron gateway link pointed at the stale 'usage_doc' branch for a
section that exists in this same README; now an in-page anchor
- developer.openstack.org/api-ref.html -> docs.openstack.org api quick start
- docs.openstack.org/developer/devstack -> docs.openstack.org/devstack/latest
- help.github.com SSH article -> docs.github.com equivalent
- contributor-covenant.org, opensource.org, openstack.org, cirros
download, rubygems.org -> canonical https targets
Plus a typo fix ('youself' -> 'yourself') on the DevStack line.
Signed-off-by: Tim Smith <tsmith84@proton.me>
tas50
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI moved to GitHub Actions some time ago —
.github/workflows/ci.ymldelegates to the sharedfog/.githubreusable workflow — so.travis.ymlis dead config. Its matrix still topped out at Ruby 2.6 and JRuby-head.Badges removed
travis-ci.orgwas decommissioned in 2021Badges modernized
The three survivors now come from shields.io, so they share one visual style and use currently-supported endpoints:
badge.fury.ioimg.shields.io/gem/vv1.1.5coveralls.ionativeimg.shields.io/coverallsCoverage98%badges.gitter.imimg.shields.io/gitter/roomchat on gitterWorth noting the old Coveralls badge had been rendering
unknown— the shields.io endpoint reports the real 98%. The Gitter link now points atapp.gitter.imdirectly rather than relying on a redirect, and drops theutm_*tracking parameters.Links fixed
Every URL in the README was checked; these were dead or redirecting:
lib/fog/openstack/docs, which does not exist. Corrected todocs.usage_docfeature branch for a section that already exists in this same README. Now an in-page#networking-neutronanchor.developer.openstack.org/api-ref.html→ the OpenStack API quick-start ondocs.openstack.orgdocs.openstack.org/developer/devstack→docs.openstack.org/devstack/latesthelp.github.comSSH-key article → thedocs.github.comequivalentcontributor-covenant.org,opensource.org/licenses/MIT,openstack.org, the cirros download, andrubygems.org→ canonicalhttpstargetsAfter the change every link resolves to its final URL with no redirect and no 404. Also fixes a
youself→yourselftypo on the DevStack line.Not included
actions/workflows/ci.yml/badge.svgcurrently rendersCI - no status, so adding it today would just reintroduce a broken badge. I am looking at that separately as part of modernizing the Actions setup.docker-compose.ymlmounts the repo at/home/travis/build/fog/fog-openstackfor the local test harness, andtest/requests/orchestration/stack_files_util_tests.rbhas atravis?helper gating two tests on that path. Happy to fold those in if you would prefer.