CHANGE @W-22393672@ Roll back ApexGuru CLI exposure for monthly release - #2067
Closed
nikhil-mittal-165 wants to merge 2 commits into
Closed
CHANGE @W-22393672@ Roll back ApexGuru CLI exposure for monthly release#2067nikhil-mittal-165 wants to merge 2 commits into
nikhil-mittal-165 wants to merge 2 commits into
Conversation
Reverts the two PRs that exposed the ApexGuru engine through the CLI, because the ApexGuru backend service is not yet available for the upcoming monthly release. Reverts: - #2059 (NEW @W-22393672@ Expose ApexGuru engine in CLI with --target-org flag) - #2064 (CHANGE @W-22393694@ bug fix on org and alias) Effect: - Removes @salesforce/code-analyzer-apexguru-engine dependency and its registration in EnginePluginsFactory, so the engine is no longer loaded. - Removes the --target-org (-o) flag and its wiring through CodeAnalyzerConfigFactory / RunAction. - ApexGuru is no longer surfaced by `run`, `rules`, or `config`, and therefore not surfaced in VS Code (which shells out to this CLI). Core (code-analyzer-core #478/#482) and VS Code (#360) changes are left in place; they are inert/dormant once the CLI no longer loads the engine. Verified: npm ci clean, build passes, affected tests green (91 passed), eligible engines no longer include apexguru.
The initial `git revert` reverted package-lock.json wholesale, which also undid an unrelated transitive bump of form-data (4.0.5 -> 4.0.6) that rode along in #2059's install. That reintroduced form-data@4.0.5, flagged by Snyk (GHSA-hmw2-7cc7-3qxx, CRLF injection, CVSS 7.5, fixed in >=4.0.6). Fix: keep the source reverts, but rebuild package-lock.json from dev's state so only the apexguru-engine dependency is dropped. All other transitive dependencies (incl. form-data@4.0.6) stay at dev's versions. Verified: build passes, 91 affected tests pass, and `npm audit --omit=dev` now matches dev exactly (form-data no longer flagged).
aruntyagiTutu
approved these changes
Jul 23, 2026
aruntyagiTutu
left a comment
aruntyagiTutu
left a comment
Contributor
There was a problem hiding this comment.
LGTM — clean revert of the ApexGuru CLI exposure (target-org flag, engine registration, config factory overrides, and associated tests) ahead of the backend not being ready for the monthly release. PR description accurately reflects the diff, and the lockfile regen preserves the form-data@4.0.6 Snyk fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the two PRs that exposed the ApexGuru engine through the CLI, because the ApexGuru backend service is not yet available for the upcoming monthly release.
Reverts:
Effect:
run,rules, orconfig, and therefore not surfaced in VS Code (which shells out to this CLI).Core (code-analyzer-core #478/#482) and VS Code (#360) changes are left in place; they are inert/dormant once the CLI no longer loads the engine.
Verified: npm ci clean, build passes, affected tests green (91 passed), eligible engines no longer include apexguru.