Skip to content

Increase sf CLI timeout from 30s to 120s #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbyrne-sf merged 2 commits into from
Jul 7, 2026
+3 −3
Merged

Increase sf CLI timeout from 30s to 120s #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc07b3e
Increase sf CLI timeout from 30s to 120s
ro-mo-do Jun 29, 2026
0073ca0
Fix test assertions to match increased timeout
ro-mo-do Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datacustomcode/token_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _run_sf_command(args: list[str], description: str) -> dict:
capture_output=True,
text=True,
check=True,
timeout=30,
timeout=120,
)
except FileNotFoundError as exc:
raise RuntimeError(
Expand Down
4 changes: 2 additions & 2 deletions tests/io/reader/test_sf_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def test_returns_token_and_instance_url(self, reader):
capture_output=True,
text=True,
check=True,
timeout=30,
timeout=120,
)
mock_run.assert_any_call(
[
Expand All @@ -114,7 +114,7 @@ def test_returns_token_and_instance_url(self, reader):
capture_output=True,
text=True,
check=True,
timeout=30,
timeout=120,
)

def test_file_not_found_raises_runtime_error(self, reader):
Expand Down
Loading