Skip to content

Add case for version variable being empty#942

Merged
kprosise merged 1 commit into
foundriesio:mainfrom
kprosise:fix-publish-build-error
Jul 21, 2026
Merged

Add case for version variable being empty#942
kprosise merged 1 commit into
foundriesio:mainfrom
kprosise:fix-publish-build-error

Conversation

@kprosise

Copy link
Copy Markdown
Contributor

While not the cause of the publishing error, which seems to have been a CI issue, this addresses instances where MP_UPDATE_VERSION is an empty string.This change leads to the docs still being published if the version variable is empty, defaulting to "latest" for the docker and manifest url replacements in the docs.

Viewed rendered docs for intended rendering across multiple cases.

This commit has no associated tracking.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck, and add redirects for any moved or deleted pages.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

While not the cause of the publishing error, which seems to have been a CI
issue, this addresses instances where `MP_UPDATE_VERSION` is an empty
string.This change leads to the docs still being published if the
version variable is empty, defaulting to "latest" for the docker and
manifest url replacements in the docs.

Viewed rendered docs for intended rendering across multiple cases.

This commit has no associated tracking.

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise
kprosise requested a review from a team July 16, 2026 11:47
@kprosise
kprosise merged commit 3727e8e into foundriesio:main Jul 21, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant