Add guide-driven physical rubber authoring - #568
Draft
freezy wants to merge 9 commits into
Draft
Conversation
Greptile SummaryThis PR adds guide-driven rubber authoring and a new physical rubber path. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| VisualPinball.Unity/VisualPinball.Unity/VPT/Rubber/RubberApi.cs | Adds physical collider generation and falls back to Legacy collision when guided data is not usable. |
| VisualPinball.Unity/VisualPinball.Unity/VPT/Rubber/RubberColliderComponent.cs | Adds rubber collider mode, physical material storage, and guided-path availability checks. |
| VisualPinball.Unity/VisualPinball.Unity/VPT/Rubber/RubberComponent.cs | Adds guided rubber state, baked path storage, restore helpers, and detach/reset behavior. |
| VisualPinball.Unity/VisualPinball.Unity.Editor/VPT/Rubber/RubberInspector.cs | Adds guided-path editing UI with delayed binding changes and failed-bake rollback. |
| VisualPinball.Unity/VisualPinball.Unity.Editor/VPT/Rubber/RubberColliderInspector.cs | Adds collider model selection and prevents enabling Physical mode without a valid guided bake. |
Reviews (3): Last reviewed commit: "rubber: harden invalid guided state" | Re-trigger Greptile
Owner
Author
|
Addressed both review findings in 31ba62d: guided binding edits now require a concrete slot and remain transactional, while invalid Physical rubber falls back to Legacy colliders. Focused autofit/collider tests pass 33/33. |
freezy
force-pushed
the
feature/rubber-system
branch
from
August 23, 2026 20:18
31ba62d to
338133c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
RubberSlingshotTestsafter final hardening (11 passed)RubberAutofitTestsandSweptCircleColliderTestsreview-fix regression suite (33 passed)git diff --checkCompatibility