Update integration tests - #322
Merged
daniel-zullo-frequenz merged 5 commits intoSep 15, 2026
Merged
daniel-zullo-frequenz merged 5 commits into
daniel-zullo-frequenz merged 5 commits into
Conversation
The endpoint is available again. Bound requests and check only test orders. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Missing orders return NOT_FOUND instead of a transient backend error. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
github-actions
Bot
added
the
part:tooling
daniel-zullo-frequenz
added
the
cmd:skip-release-notes
daniel-zullo-frequenz
marked this pull request as ready for review
September 15, 2026 11:25
Prevent the token from inheriting broader repository permissions. Signed-off-by: Daniel Zullo <daniel.zullo@frequenz.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused test and configuration updates are consistent with the client behavior and introduce no unresolved issues.
Pull request overview
Updates integration testing behavior and CI configuration.
Changes:
- Re-enables and strengthens cancel-all order testing.
- Expects
NOT_FOUNDfor missing orders. - Improves formatting configuration and workflow permissions.
File summaries
| File | Description |
|---|---|
pyproject.toml |
Includes integration tests in isort and fixes a comment typo. |
integration_tests/test_api.py |
Restores cancel-all coverage and updates error expectations. |
.github/workflows/integration_test.yml |
Restricts workflow permissions to read-only contents. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
phillip-wenig-frequenz
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.