Declare missing direct dependencies - #303
Merged
Merged
Conversation
llucax
requested review from
ela-kotulska-frequenz
and removed request for
a team
September 17, 2026 08:03
github-actions
Bot
added
part:docs
llucax
enabled auto-merge
September 17, 2026 08:08
llucax
disabled auto-merge
September 17, 2026 08:14
daniel-zullo-frequenz
previously approved these changes
Sep 17, 2026
llucax
force-pushed
the
add-missing-deps
branch
from
September 17, 2026 08:46
54ca765 to
0e16a13
Compare
Contributor
Author
|
Updated, needs a new approval. |
llucax
enabled auto-merge
September 17, 2026 08:47
daniel-zullo-frequenz
previously approved these changes
Sep 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 17, 2026
llucax
force-pushed
the
add-missing-deps
branch
from
September 17, 2026 09:01
0e16a13 to
7c7c1b6
Compare
llucax
enabled auto-merge
September 17, 2026 09:04
Contributor
Author
|
Whoops. New conflict. Updated again, and added a new commit to fix the format and cleanup the release notes. |
daniel-zullo-frequenz
previously approved these changes
Sep 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2026
llucax
force-pushed
the
add-missing-deps
branch
from
September 17, 2026 10:14
e5cca10 to
84b0018
Compare
llucax
force-pushed
the
add-missing-deps
branch
from
September 17, 2026 10:15
84b0018 to
69b3bc9
Compare
The package imports `frequenz.client.common`, `frequenz.core` and `grpc` directly, but none of them was declared in pyproject.toml; they were only pulled in transitively through `frequenz-client-dispatch`. If that client changed its own requirements (for example to accept `frequenz-client-common` v0.4.x), this library could break without any warning from the resolver. Declare all three explicitly. `frequenz-client-common` is pinned to `>= 0.3.8, < 0.4.0` as the issue suggests and `frequenz-core` follows what the minimum supported `frequenz-client-dispatch` (0.11.3) requires. The `grpcio` floor is 1.80.0 because `frequenz-client-common` 0.3.8 needs `frequenz-api-common >= 0.8.4`, which itself requires `grpcio >= 1.80`. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This will be rendered by GitHub releases, which preserves new lines, so it looks better if we don't manually wrap. Also remove placeholders, as the release will happen soon and will not get new features or content for the currently empty sections. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
add-missing-deps
branch
from
September 17, 2026 10:17
69b3bc9 to
b24ff6b
Compare
Contributor
Author
|
The min dependencies were wrong and |
llucax
enabled auto-merge
September 17, 2026 10:18
daniel-zullo-frequenz
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package imports
frequenz.client.common,frequenz.coreandgrpcdirectly, but none of them was declared inpyproject.toml; they were only pulled in transitively throughfrequenz-client-dispatch. If that client changed its own requirements (for example to acceptfrequenz-client-commonv0.4.x), this library could break without any warning from the resolver.This declares all three explicitly. The version ranges follow what the minimum supported
frequenz-client-dispatch(0.11.3) requires, withfrequenz-client-commonat>= 0.3.8, < 0.4.0as suggested in the issue, so the constraints stay consistent with the dispatch client. Thegrpciofloor is 1.80.0 becausefrequenz-client-common0.3.8 needsfrequenz-api-common >= 0.8.4, which itself requiresgrpcio >= 1.80.Fixes #302.