Skip to content

perf(SourceLength): String.Concat -> StringBuilder #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Numpsy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(SourceLength): String.Concat -> StringBuilder #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/FSharpLint.Core/Rules/Conventions/SourceLength/SourceLengthHelper.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module FSharpLint.Rules.Helper.SourceLength

open System
open System.Text
open System.Text.RegularExpressions
open FSharpLint.Framework
open FSharpLint.Framework.Suggestion
Expand Down Expand Up @@ -51,13 +52,15 @@ let checkSourceLengthRule (config:Config) range fileContents errorName (skipRang
|> Seq.sortBy (function | Begin index -> index | End index -> index)
|> Seq.toList

getTopLevelBalancedPairs markers List.Empty
|> List.fold
(fun (currSource: string) (startIndex, endIndex) ->
let left = currSource.AsSpan(0, startIndex)
let right = currSource.AsSpan(endIndex + multilineCommentMarkerRegexCaptureGroupLength)
String.Concat(left, right))
source
match getTopLevelBalancedPairs markers List.Empty with
| [] -> source
| pairs ->

(StringBuilder(source), pairs)
||> List.fold
(fun (currSource: StringBuilder) (startIndex, endIndex) ->
currSource.Remove(startIndex, (endIndex + multilineCommentMarkerRegexCaptureGroupLength) - startIndex))
|> _.ToString()

match tryFindTextOfRange range fileContents with
| Some(sourceCode) ->
Expand Down
Loading