Skip to content

Add support for publishing_group per ADR0037 - #160

Merged
nkraetzschmar merged 1 commit into
mainfrom
feat/adr0037
Aug 14, 2026
Merged

Add support for publishing_group per ADR0037#160
nkraetzschmar merged 1 commit into
mainfrom
feat/adr0037

Conversation

@Gchbg

@Gchbg Gchbg commented Aug 4, 2026

Copy link
Copy Markdown
Member

Release note:

Add support for publishing_group

@nkraetzschmar

Copy link
Copy Markdown
Contributor

I'm not sure this addition of default values to the requirements_keys array is the cleanest approach here. Maybe if we now in addition to defining what the available keys are we also want to dynamically set their default values, it might be a good idea to rethink the approach that the set of possible requirement keys is defined by features.

Instead a cleaner option might be to introduce one top level requirements.def file (next to the get_repo and similar files) that both defines the keys of all known requirements as well as their default values. The per feature requirements.mod files then simply operate on these variables.

This would also let us revert #151 which was only added to enable discovery of requirements in features that are not included.

@nkraetzschmar
nkraetzschmar merged commit 0196add into main Aug 14, 2026
6 of 7 checks passed
@nkraetzschmar
nkraetzschmar deleted the feat/adr0037 branch August 14, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants