You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure this addition of default values to the requirements_keys array is the cleanest approach here. Maybe if we now in addition to defining what the available keys are we also want to dynamically set their default values, it might be a good idea to rethink the approach that the set of possible requirement keys is defined by features.
Instead a cleaner option might be to introduce one top level requirements.def file (next to the get_repo and similar files) that both defines the keys of all known requirements as well as their default values. The per feature requirements.mod files then simply operate on these variables.
This would also let us revert #151 which was only added to enable discovery of requirements in features that are not included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: