Fix archive confirmation counts and compact dialog spacing - #4377
Merged
ymichael merged 3 commits intoSep 26, 2026
Merged
Conversation
ymichael
deleted the
bb/fix-incorrect-archive-confirmation-count-thr_xsih3hfxsi
branch
September 26, 2026 03:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Archive confirmation reused deletion's direct-child count, including already archived children and missing deeper descendants. A parent whose only child was already archived incorrectly prompted to archive two threads. The shared DialogFooter also supplied horizontal desktop spacing but no spacing between stacked mobile buttons. Related: #3399.
What changed
Archive preview now counts unarchived, non-deleted descendants using the same traversal as archive-all, including live descendants below archived intermediaries and deduplicating hierarchy, lifecycle-owner, and hidden source-fork relationships. Deletion retains its direct non-deleted count. The existing SDK childSummary response exposes unarchivedDescendantCount; CLI/SDK archive operations remain non-interactive. Plugin SDK is bumped to 0.5.30 for its updated bundled response types, and the plugin registry dialog copy is regenerated. Shared dialog footers use an 8px gap at both compact and desktop widths. No daemon wire changes.
How you verified
50a71995fa: all 16 active CI checks passed; iOS simulator flows and Node Compatibility Smoke were skipped.