Enable manual compaction for built-in Grok ACP provider - #4386
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The built-in Grok ACP provider inherited the ACP default of
supportsManualCompaction: false. The server rejected compaction with HTTP 409 before dispatching to the ACP bridge. The verified reproduction and root-cause report records the failure in two clean checkouts.What changed
Enabled manual compaction for the built-in Grok ACP provider, extended the public thread compaction test to cover its request, updated the existing provider expectation, and documented the CLI behavior in the ACP provider skill. No protocol or wire fields changed. The diff has 76 changed text lines across four files, with no binary changes.
How you verified
pnpm exec turbo run lint typecheck --filter=@bb/server --filter=bb-plugin-provider-acppassed.git diff --check origin/mainpassed.Fixes #4378