fix(captioning): correct web-demuxer.wasm URL — transcription always failed with "Failed to fetch" - #370
Open
superkc2026 wants to merge 1 commit into
Open
Conversation
…failed with "Failed to fetch" The captioning demuxer resolved web-demuxer.wasm from `../exporter/wasm/`, but the asset ships in `public/wasm/` and is emitted at `dist/wasm/` next to the renderer entry — so the resolved URL 404s in both dev and packaged builds, and every transcription run fails at wasm fetch. The two other consumers (streamingAudioPeaks.ts, streamingDecoder.ts) already use `./wasm/`; this aligns the last one.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe WebDemuxer WASM asset URL now points to the local ChangesWebDemuxer asset loading
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized URL correction restores wasm loading for transcription and is reported to work in the packaged build; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every transcription run fails with
Failed to fetch— in dev and in packaged builds.Root cause
extractMono16kWebDemuxer.tsresolves the web-demuxer wasm from:but the asset lives in
public/wasm/and is emitted atdist/wasm/, next to the renderer entry. The resolved URL 404s, sonew WebDemuxer(...)dies at the wasm fetch step and transcription never starts.Fix
Align it with the two other consumers (
streamingAudioPeaks.ts,streamingDecoder.ts), which already use the correct relative path:Testing
Summary by CodeRabbit