Skip to content

docs(testing): "the machine is at 100%" is not a reason to skip DPI - #372

Merged
EtienneLescot merged 1 commit into
mainfrom
claude/dpi-not-a-constraint
Aug 14, 2026
Merged

docs(testing): "the machine is at 100%" is not a reason to skip DPI#372
EtienneLescot merged 1 commit into
mainfrom
claude/dpi-not-a-constraint

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #369, which merged one commit before this one landed.

The results row justified skipping DPI coverage with "this machine is 100% — those bugs are structurally invisible here". That is wrong, and wrong in a way worth correcting in the record rather than quietly: the display scale is a setting. Changing it takes about two minutes, and driving Settings to do it has been the documented procedure since #346.

So the honest sentence is "not re-run in this pass" — it was already validated when 60bb6d7c and 71cc88d6 landed. Skipping was a choice. Left skipped, but the reason now says that instead of dressing a choice up as a constraint, which is exactly how a coverage gap outlives the release it was skipped for.

One line, docs only. check-docs green.

Summary by CodeRabbit

  • Documentation
    • Updated the Windows regression checklist with broader validation results.
    • Added checks for recovered-recording exports, capture, audio, compositor, persistence, and tray behavior.
    • Clarified DPI scaling guidance for future testing.

The row justified skipping DPI coverage with "this machine is 100% —
those bugs are structurally invisible here". The display scale is a
setting. Changing it takes about two minutes and has been the documented
procedure since #346, so the honest sentence was "not re-run in this
pass", not "cannot be tested here".

Left as not-covered, because it was already validated when 60bb6d7 and
71cc88d landed, but the reason now says that instead of dressing a
choice up as a constraint — which is exactly how a gap outlives the
release it was skipped for.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 20325ae4-b603-43a8-a1d9-43d4e7397c07

📥 Commits

Reviewing files that changed from the base of the PR and between a115949 and 4bd008e.

📒 Files selected for processing (1)
  • technical-documentation/testing/manual-e2e-checklist.md

📝 Walkthrough

Walkthrough

The Windows release regression log now includes broader validation results and updated guidance for re-testing DPI scaling.

Changes

Windows regression documentation

Layer / File(s) Summary
Expand regression results and DPI guidance
technical-documentation/testing/manual-e2e-checklist.md
The checklist adds results for fragmented-MP4 export, capture pacing, waveform and audio muxing, compositor behavior, persistence, helper recovery, export, and tray behavior. The DPI note now records prior validation and instructs testers to change the display scale for re-testing.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4bd00

This is a one-line documentation correction with no production behavior change, so no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, but it omits the required template sections and does not provide complete issue, change type, impact, or testing details. Add the template headings and complete the related issue, type of change, release impact, desktop impact, screenshots or video, and testing sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change about incorrectly skipping DPI testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/dpi-not-a-constraint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit d3da292 into main Aug 14, 2026
17 checks passed
@EtienneLescot
EtienneLescot deleted the claude/dpi-not-a-constraint branch August 14, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant