Skip to content

fix(store): the option is --inputDirectory, and it takes a directory #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtienneLescot wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

fix(store): the option is --inputDirectory, and it takes a directory #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,7 @@ jobs:

# `msstore publish` takes a PROJECT root, not a package: it detects the app
# type there (Electron, via package.json) and only then accepts the built
# package through `--inputFile`. This job used to check nothing out, so
# package through `--inputDirectory`. This job used to check nothing out, so
# there was no project to point it at. Checkout runs before the artifact
# download on purpose — actions/checkout cleans the workspace, and would
# delete the package if it ran after.
Expand Down Expand Up @@ -1058,8 +1058,11 @@ jobs:
# The positional argument is the project root, NOT the package — passing
# the .appx there is what failed the first real run of this job on
# v1.9.5: "We could not find a project publisher for the project at
# ...Openscreen.Setup.1.9.5.appx". The package goes through --inputFile.
msstore publish . --inputFile $appx.FullName --appId $env:PRODUCT_ID
# ...Openscreen.Setup.1.9.5.appx". The package goes through the option
# below, which takes the DIRECTORY holding it — the CLI's own usage
# says `-i, --inputDirectory`, and rejects the `--inputFile` that
# Microsoft Learn documents. The binary wins.
msstore publish . --inputDirectory $appx.Directory.FullName --appId $env:PRODUCT_ID

# Report what happened, not what was configured. Keyed off `enabled` alone
# under always(), this claimed "Submitted to the Store" when `msstore
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/publish-msstore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,12 @@ jobs:

# The positional argument is the project root, NOT the package: passing
# the package there is what failed v1.9.5 ("could not find a project
# publisher"). The package goes through --inputFile.
# publisher"). The package goes through the option below, which takes
# the DIRECTORY holding it: the CLI's own usage says
# `-i, --inputDirectory`, and rejects the `--inputFile` that Microsoft
# Learn documents. The v1.9.5 dry run is what caught that.
# Not $args: that is a PowerShell automatic variable.
$cmdArgs = @('publish', '.', '--inputFile', $pkg.FullName, '--appId', $env:PRODUCT_ID)
$cmdArgs = @('publish', '.', '--inputDirectory', $pkg.Directory.FullName, '--appId', $env:PRODUCT_ID)
if ($env:DRY_RUN -eq 'true') {
# Leaves the submission in draft instead of sending it to
# certification: the only way to test this path without shipping.
Expand Down
Loading