fix(preprod): Accept CFBundleVersion groups beyond the third - #657
Merged
Conversation
_parse_build_number rejected period-separated build numbers with more than three groups. The CFBundleVersion spec allows extra groups and requires parsers to drop groups beyond the third, so 1.2.3.4 now packs to the same build number as 1.2.3. All groups must still be numeric; only the first three are width-checked. Mirrors sentry's parse_build_number in build_distribution_utils.py. Deploy only after the sentry backend change is live, so query-side parsing accepts the extra groups before launchpad starts producing them.
Contributor
📲 Install BuildsiOS
Android
|
Contributor
Size Analysis2 components analyzed iOS Builds
Android Builds
|
trevor-e
marked this pull request as ready for review
August 13, 2026 18:28
chromy
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parse_build_numberrejected period-separated build numbers with more than three integer groups (e.g.1.2.3.4). The CFBundleVersion spec allows extra groups and requires parsers to drop groups beyond the third, so such build numbers now pack to the same integer as their first three groups (1.2.3.4->1.2.3). All groups must still be numeric (1.2.3.betastays rejected), and only the first three groups are width-checked. Mirrors sentry'sparse_build_numberinbuild_distribution_utils.py(getsentry/sentry#121968).Deploy only after the sentry backend change is live, so query-side parsing accepts the extra groups before launchpad starts producing them.